Skip to content

Comments

fix(ast)!: add missing ChainExpression from TSNonNullExpression#7377

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-20-fix_ast_add_missing_chainexpression_from_tsnonnullexpression_
Nov 20, 2024
Merged

fix(ast)!: add missing ChainExpression from TSNonNullExpression#7377
graphite-app[bot] merged 1 commit intomainfrom
11-20-fix_ast_add_missing_chainexpression_from_tsnonnullexpression_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 20, 2024

closes #7375

  • foo?.bar!
  • foo?.[bar]!

TSNonNullExpression was not wrapped inside ChainExpression.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier C-bug Category - Bug labels Nov 20, 2024
Copy link
Member Author

Boshen commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 20, 2024

Merge activity

…7377)

closes #7375

* `foo?.bar!`
* `foo?.[bar]!`

`TSNonNullExpression` was not wrapped inside `ChainExpression`.
@Boshen Boshen force-pushed the 11-20-fix_ast_add_missing_chainexpression_from_tsnonnullexpression_ branch from 7a4a1f2 to f059b0e Compare November 20, 2024 15:54
@graphite-app graphite-app bot merged commit f059b0e into main Nov 20, 2024
@graphite-app graphite-app bot deleted the 11-20-fix_ast_add_missing_chainexpression_from_tsnonnullexpression_ branch November 20, 2024 15:59
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #7377 will not alter performance

Comparing 11-20-fix_ast_add_missing_chainexpression_from_tsnonnullexpression_ (f059b0e) with main (878189c)

Summary

✅ 30 untouched benchmarks

This was referenced Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ast: missing ChainExpression in foo?.bar!

1 participant