Skip to content

Comments

feat(traverse): implement GatherNodeParts for member expression types#7363

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types
Nov 20, 2024
Merged

feat(traverse): implement GatherNodeParts for member expression types#7363
graphite-app[bot] merged 1 commit intomainfrom
11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 19, 2024

GatherNodeParts was missing support for these types as entry points for collection.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

@overlookmotel overlookmotel changed the title fix(traverse): implement GatherNodeParts for member expression types feat(traverse): implement GatherNodeParts for member expression types Nov 19, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 19, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 19, 2024 18:02
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #7363 will not alter performance

Comparing 11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types (234c7b9) with main (c587dd3)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 20, 2024
Copy link
Member

Dunqing commented Nov 20, 2024

Merge activity

  • Nov 19, 10:58 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 19, 10:58 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 19, 11:03 PM EST: A user merged this pull request with the Graphite merge queue.

…es (#7363)

`GatherNodeParts` was missing support for these types as entry points for collection.
@Dunqing Dunqing force-pushed the 11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types branch from e0bcde3 to 234c7b9 Compare November 20, 2024 03:58
@graphite-app graphite-app bot merged commit 234c7b9 into main Nov 20, 2024
@graphite-app graphite-app bot deleted the 11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types branch November 20, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue C-bug Category - Bug C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants