perf(ast): AstBuilder::vec1 use Vec::from_array_in#7334
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 18, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This was referenced Nov 17, 2024
AstBuilder::vec1 use Vec::from_array_inAstBuilder::vec1 use Vec::from_array_in
CodSpeed Performance ReportMerging #7334 will not alter performanceComparing Summary
|
e26de29 to
cff2b8a
Compare
Member
Merge activity
|
`AstBuilder::vec1` can use `Vec::from_array_in` rather than creating a `Vec` and then pushing to it. This should optimize better.
94f3e0a to
510b95d
Compare
cff2b8a to
c84e892
Compare
Base automatically changed from
11-17-refactor_transformer_use_astbuilder_vec_from_array_
to
main
November 18, 2024 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

AstBuilder::vec1can useVec::from_array_inrather than creating aVecand then pushing to it. This should optimize better.