Skip to content

Comments

perf(ast): AstBuilder::vec1 use Vec::from_array_in#7334

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-17-refactor_ast_astbuilder_vec1_use_vec_from_array_in_
Nov 18, 2024
Merged

perf(ast): AstBuilder::vec1 use Vec::from_array_in#7334
graphite-app[bot] merged 1 commit intomainfrom
11-17-refactor_ast_astbuilder_vec1_use_vec_from_array_in_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 17, 2024

AstBuilder::vec1 can use Vec::from_array_in rather than creating a Vec and then pushing to it. This should optimize better.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Nov 17, 2024

@overlookmotel overlookmotel changed the title refactor(ast): AstBuilder::vec1 use Vec::from_array_in perf(ast): AstBuilder::vec1 use Vec::from_array_in Nov 17, 2024
@github-actions github-actions bot added A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance labels Nov 17, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 17, 2024 19:56
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #7334 will not alter performance

Comparing 11-17-refactor_ast_astbuilder_vec1_use_vec_from_array_in_ (c84e892) with main (1938a1d)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 11-17-refactor_ast_astbuilder_vec1_use_vec_from_array_in_ branch from e26de29 to cff2b8a Compare November 17, 2024 19:59
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 18, 2024
Copy link
Member

Boshen commented Nov 18, 2024

Merge activity

  • Nov 17, 9:30 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 17, 9:30 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 17, 9:52 PM EST: A user merged this pull request with the Graphite merge queue.

`AstBuilder::vec1` can use `Vec::from_array_in` rather than creating a `Vec` and then pushing to it. This should optimize better.
@Boshen Boshen force-pushed the 11-17-refactor_transformer_use_astbuilder_vec_from_array_ branch from 94f3e0a to 510b95d Compare November 18, 2024 02:36
@Boshen Boshen force-pushed the 11-17-refactor_ast_astbuilder_vec1_use_vec_from_array_in_ branch from cff2b8a to c84e892 Compare November 18, 2024 02:37
Base automatically changed from 11-17-refactor_transformer_use_astbuilder_vec_from_array_ to main November 18, 2024 02:47
@graphite-app graphite-app bot merged commit c84e892 into main Nov 18, 2024
@graphite-app graphite-app bot deleted the 11-17-refactor_ast_astbuilder_vec1_use_vec_from_array_in_ branch November 18, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants