Skip to content

Comments

feat(transformer): support generate proper binding name from ChainExpression#7326

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression
Nov 19, 2024
Merged

feat(transformer): support generate proper binding name from ChainExpression#7326
graphite-app[bot] merged 1 commit intomainfrom
11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 17, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Nov 17, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #7326 will not alter performance

Comparing 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression (6cfb5df) with main (65f1e82)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing force-pushed the 11-17-refactor_codegen_avoid_printing_unnecessary_parentheses_for_chainexpression_inside_logicalexpression branch from dddea2a to 00d7921 Compare November 19, 2024 08:12
@Dunqing Dunqing force-pushed the 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression branch 2 times, most recently from f1ee475 to 2762481 Compare November 19, 2024 08:25
@Dunqing Dunqing marked this pull request as ready for review November 19, 2024 08:28
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 19, 2024
Copy link
Member

Boshen commented Nov 19, 2024

Merge activity

  • Nov 19, 5:31 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 19, 5:31 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 19, 5:39 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-17-refactor_codegen_avoid_printing_unnecessary_parentheses_for_chainexpression_inside_logicalexpression branch from 00d7921 to 58db9ef Compare November 19, 2024 10:32
@Boshen Boshen force-pushed the 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression branch from 2762481 to 6cfb5df Compare November 19, 2024 10:32
Base automatically changed from 11-17-refactor_codegen_avoid_printing_unnecessary_parentheses_for_chainexpression_inside_logicalexpression to main November 19, 2024 10:36
@graphite-app graphite-app bot merged commit 6cfb5df into main Nov 19, 2024
@graphite-app graphite-app bot deleted the 11-17-feat_transformer_support_generate_proper_binding_name_from_chainexpression branch November 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants