Skip to content

refactor(transformer/arrow-function): comments on possible improvement #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 17, 2024
Merged

refactor(transformer/arrow-function): comments on possible improvement #7320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/oxc_transformer/src/common/arrow_function_converter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,8 @@ impl<'a> ArrowFunctionConverter<'a> {

// Create a parameter for the prop if it's a computed member expression.
if is_computed {
// TODO(improve-on-babel): No need for UID here. Just `prop` would be fine as there's nothing
// in `prop => super[prop]` or `(prop, value) => super[prop] = value` which can clash.
let param_binding =
ctx.generate_uid("prop", scope_id, SymbolFlags::FunctionScopedVariable);
let param = ctx.ast.formal_parameter(
Expand All @@ -771,6 +773,8 @@ impl<'a> ArrowFunctionConverter<'a> {

// Create a parameter for the value if it's an assignment.
if is_assignment {
// TODO(improve-on-babel): No need for UID here. Just `value` would be fine as there's nothing
// in `value => super.prop = value` or `(prop, value) => super[prop] = value` which can clash.
let param_binding =
ctx.generate_uid("value", scope_id, SymbolFlags::FunctionScopedVariable);
let param = ctx.ast.formal_parameter(
Expand Down