feat(traverse): add methods for creating Expression::Identifiers#7301
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 16, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
CodSpeed Performance ReportMerging #7301 will not alter performanceComparing Summary
|
This was referenced Nov 15, 2024
Contributor
Merge activity
|
Boshen
pushed a commit
that referenced
this pull request
Nov 16, 2024
…7301) It's a common pattern in transformer to call `ctx.create_ident_reference()` and then convert to an `Expression` with `Expression::Identifier(ctx.ast.alloc(ident))`. Add methods to do this in a single method call.
Boshen
force-pushed
the
11-15-feat_traverse_add_methods_for_creating_expression_identifier_s
branch
from
6e7d767 to
fcd6c3d
Compare
…7301) It's a common pattern in transformer to call `ctx.create_ident_reference()` and then convert to an `Expression` with `Expression::Identifier(ctx.ast.alloc(ident))`. Add methods to do this in a single method call.
Boshen
force-pushed
the
11-15-feat_traverse_add_methods_for_creating_expression_identifier_s
branch
from
fcd6c3d to
faf8dde
Compare
graphite-app
bot
deleted the
11-15-feat_traverse_add_methods_for_creating_expression_identifier_s
branch
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
…7301) It's a common pattern in transformer to call `ctx.create_ident_reference()` and then convert to an `Expression` with `Expression::Identifier(ctx.ast.alloc(ident))`. Add methods to do this in a single method call.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
…7301) It's a common pattern in transformer to call `ctx.create_ident_reference()` and then convert to an `Expression` with `Expression::Identifier(ctx.ast.alloc(ident))`. Add methods to do this in a single method call.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
…7301) It's a common pattern in transformer to call `ctx.create_ident_reference()` and then convert to an `Expression` with `Expression::Identifier(ctx.ast.alloc(ident))`. Add methods to do this in a single method call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a common pattern in transformer to call
ctx.create_ident_reference()and then convert to anExpressionwithExpression::Identifier(ctx.ast.alloc(ident)).Add methods to do this in a single method call.