Skip to content

Comments

fix(minifier): do not compare bigint with object#7294

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-15-fix_minifier_fix_test262_exec_errors_in_bigint_object_comparison
Nov 16, 2024
Merged

fix(minifier): do not compare bigint with object#7294
graphite-app[bot] merged 1 commit intomainfrom
11-15-fix_minifier_fix_test262_exec_errors_in_bigint_object_comparison

Conversation

@7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 15, 2024

@Boshen, could you please update the snap of runtime and commit to this PR? I want to see the effects after the unit tests are added.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-minifier Area - Minifier label Nov 15, 2024
Copy link
Contributor Author

7086cmd commented Nov 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Nov 15, 2024
@7086cmd 7086cmd requested a review from Boshen November 15, 2024 12:57
@7086cmd 7086cmd marked this pull request as ready for review November 15, 2024 12:57
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #7294 will not alter performance

Comparing 11-15-fix_minifier_fix_test262_exec_errors_in_bigint_object_comparison (cf99be0) with main (20d9080)

Summary

✅ 30 untouched benchmarks

@7086cmd 7086cmd force-pushed the 11-15-fix_minifier_fix_test262_exec_errors_in_bigint_object_comparison branch from 2d58a1b to 9a4669a Compare November 16, 2024 04:15
@Boshen Boshen changed the title fix(minifier): fix test262 exec errors in bigint object comparison fix(minifier): do not compare bigint with object Nov 16, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 16, 2024
Copy link
Member

Boshen commented Nov 16, 2024

Merge activity

  • Nov 16, 12:40 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 16, 12:40 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 16, 12:49 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 16, 1:07 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen, could you please update the snap of runtime and commit to this PR? I want to see the effects after the unit tests are added.
@Boshen Boshen force-pushed the 11-15-fix_minifier_fix_test262_exec_errors_in_bigint_object_comparison branch from 408ff1a to cf99be0 Compare November 16, 2024 06:01
@graphite-app graphite-app bot merged commit cf99be0 into main Nov 16, 2024
@graphite-app graphite-app bot deleted the 11-15-fix_minifier_fix_test262_exec_errors_in_bigint_object_comparison branch November 16, 2024 06:07
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
@Boshen, could you please update the snap of runtime and commit to this PR? I want to see the effects after the unit tests are added.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
@Boshen, could you please update the snap of runtime and commit to this PR? I want to see the effects after the unit tests are added.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
@Boshen, could you please update the snap of runtime and commit to this PR? I want to see the effects after the unit tests are added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants