Skip to content

Comments

refactor(transformer/nullish-coalescing): split main logic into separate function#7273

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-13-refactor_transformer_nullish-coalescing_split_main_logic_into_separate_function
Nov 14, 2024
Merged

refactor(transformer/nullish-coalescing): split main logic into separate function#7273
graphite-app[bot] merged 1 commit intomainfrom
11-13-refactor_transformer_nullish-coalescing_split_main_logic_into_separate_function

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 13, 2024

Small refactor. Move main logic of the transform into a separate function, to allow enter_expression to be inlined.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Nov 13, 2024

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 13, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2024 15:52
@overlookmotel overlookmotel force-pushed the 11-13-refactor_transformer_nullish-coalescing_avoid_repeated_symbol_lookups branch from d23e8da to 4ced135 Compare November 13, 2024 15:57
@overlookmotel overlookmotel force-pushed the 11-13-refactor_transformer_nullish-coalescing_split_main_logic_into_separate_function branch from 8524b30 to 060bdd6 Compare November 13, 2024 15:57
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #7273 will not alter performance

Comparing 11-13-refactor_transformer_nullish-coalescing_split_main_logic_into_separate_function (9f5ae56) with main (01ddf37)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 14, 2024
Copy link
Member

Boshen commented Nov 14, 2024

Merge activity

  • Nov 14, 11:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 11:16 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 11:35 AM EST: A user merged this pull request with the Graphite merge queue.

…ate function (#7273)

Small refactor. Move main logic of the transform into a separate function, to allow `enter_expression` to be inlined.
@Boshen Boshen force-pushed the 11-13-refactor_transformer_nullish-coalescing_avoid_repeated_symbol_lookups branch from 4ced135 to 345fbb9 Compare November 14, 2024 16:18
@Boshen Boshen force-pushed the 11-13-refactor_transformer_nullish-coalescing_split_main_logic_into_separate_function branch from 060bdd6 to 9f5ae56 Compare November 14, 2024 16:19
Base automatically changed from 11-13-refactor_transformer_nullish-coalescing_avoid_repeated_symbol_lookups to main November 14, 2024 16:32
@graphite-app graphite-app bot merged commit 9f5ae56 into main Nov 14, 2024
@graphite-app graphite-app bot deleted the 11-13-refactor_transformer_nullish-coalescing_split_main_logic_into_separate_function branch November 14, 2024 16:35
Dunqing pushed a commit that referenced this pull request Nov 17, 2024
…ate function (#7273)

Small refactor. Move main logic of the transform into a separate function, to allow `enter_expression` to be inlined.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
…ate function (#7273)

Small refactor. Move main logic of the transform into a separate function, to allow `enter_expression` to be inlined.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
…ate function (#7273)

Small refactor. Move main logic of the transform into a separate function, to allow `enter_expression` to be inlined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants