Skip to content

Comments

refactor(ast): move StringLiteral definition higher up#7270

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-13-refactor_ast_move_stringliteral_definition_higher_up
Nov 13, 2024
Merged

refactor(ast): move StringLiteral definition higher up#7270
graphite-app[bot] merged 1 commit intomainfrom
11-13-refactor_ast_move_stringliteral_definition_higher_up

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 13, 2024

Pure refactor. StringLiteral definition was sandwiched in the middle of RegExp-related code. Move it higher up in literal.rs.

All the rest of the diff is just re-ordering generated code.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Nov 13, 2024

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 13, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2024 13:35
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
Copy link
Member Author

overlookmotel commented Nov 13, 2024

Merge activity

  • Nov 13, 8:35 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 8:37 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 8:42 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel
Copy link
Member Author

This change was originally part of #7263. Have split it out into a separate PR to make the substantive changes in #7263 easier to review.

Pure refactor. `StringLiteral` definition was sandwiched in the middle of RegExp-related code. Move it higher up in `literal.rs`.

All the rest of the diff is just re-ordering generated code.
@overlookmotel overlookmotel force-pushed the 11-13-refactor_ast_move_stringliteral_definition_higher_up branch from 858411b to de472ca Compare November 13, 2024 13:37
@graphite-app graphite-app bot merged commit de472ca into main Nov 13, 2024
@graphite-app graphite-app bot deleted the 11-13-refactor_ast_move_stringliteral_definition_higher_up branch November 13, 2024 13:42
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #7270 will not alter performance

Comparing 11-13-refactor_ast_move_stringliteral_definition_higher_up (de472ca) with main (834c94d)

Summary

✅ 30 untouched benchmarks

Dunqing pushed a commit that referenced this pull request Nov 17, 2024
Pure refactor. `StringLiteral` definition was sandwiched in the middle of RegExp-related code. Move it higher up in `literal.rs`.

All the rest of the diff is just re-ordering generated code.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Pure refactor. `StringLiteral` definition was sandwiched in the middle of RegExp-related code. Move it higher up in `literal.rs`.

All the rest of the diff is just re-ordering generated code.
Dunqing pushed a commit that referenced this pull request Nov 18, 2024
Pure refactor. `StringLiteral` definition was sandwiched in the middle of RegExp-related code. Move it higher up in `literal.rs`.

All the rest of the diff is just re-ordering generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant