Skip to content

fix(linter): react/exhaustive-deps update span for unknown deps diagnostic #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 12, 2024
Merged

fix(linter): react/exhaustive-deps update span for unknown deps diagnostic #7249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/react_hooks/exhaustive_deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ impl Rule for ExhaustiveDeps {
Argument::SpreadElement(_) => {
ctx.diagnostic(unknown_dependencies_diagnostic(
hook_name.as_str(),
callback_node.span(),
call_expr.callee.span(),
));
None
}
Expand Down Expand Up @@ -312,7 +312,7 @@ impl Rule for ExhaustiveDeps {
_ => {
ctx.diagnostic(unknown_dependencies_diagnostic(
hook_name.as_str(),
callback_node.span(),
call_expr.callee.span(),
));
None
}
Expand Down
11 changes: 5 additions & 6 deletions crates/oxc_linter/src/snapshots/exhaustive_deps.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1953,12 +1953,11 @@ source: crates/oxc_linter/src/tester.rs
help: Either include it or remove the dependency array.

⚠ react_hooks(exhaustive-deps): React Hook useEffect received a function whose dependencies are unknown.
╭─[exhaustive_deps.tsx:3:21]
2 │ const local = {};
3 │ ╭─▶ useEffect(debounce(() => {
4 │ │ console.log(local);
5 │ ╰─▶ }, delay), []);
6 │ }
╭─[exhaustive_deps.tsx:3:11]
2 │ const local = {};
3 │ useEffect(debounce(() => {
· ─────────
4 │ console.log(local);
╰────
help: Pass an inline function instead.

Expand Down