Skip to content

Comments

fix(codegen): print comments when block is empty#7236

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-11-fix_codegen_print_statements_when_block_is_empty
Nov 11, 2024
Merged

fix(codegen): print comments when block is empty#7236
graphite-app[bot] merged 1 commit intomainfrom
11-11-fix_codegen_print_statements_when_block_is_empty

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 11, 2024

part of #7190

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Nov 11, 2024
Copy link
Member Author

Boshen commented Nov 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #7236 will not alter performance

Comparing 11-11-fix_codegen_print_statements_when_block_is_empty (1282221) with main (0d6a66a)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen changed the title fix(codegen): print statements when block is empty fix(codegen): print comments when block is empty Nov 11, 2024
@Boshen Boshen force-pushed the 11-11-fix_codegen_print_statements_when_block_is_empty branch 2 times, most recently from 2412ee8 to 57127c4 Compare November 11, 2024 11:15
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2024

Merge activity

@Boshen Boshen force-pushed the 11-11-fix_codegen_print_statements_when_block_is_empty branch from 57127c4 to 1282221 Compare November 11, 2024 11:20
@graphite-app graphite-app bot merged commit 1282221 into main Nov 11, 2024
@graphite-app graphite-app bot deleted the 11-11-fix_codegen_print_statements_when_block_is_empty branch November 11, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant