Skip to content

refactor(transformer/async-generator-functions): remove useless code for handle await expression #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 6, 2024
Merged

refactor(transformer/async-generator-functions): remove useless code for handle await expression #7131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 3 additions & 28 deletions crates/oxc_transformer/src/es2018/async_generator_functions/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,35 +222,10 @@ impl<'a, 'ctx> AsyncGeneratorFunctions<'a, 'ctx> {
return None;
}

let mut is_function = false;
let mut function_in_params = false;
for ancestor in ctx.ancestors() {
match ancestor {
Ancestor::FunctionBody(_) if !is_function => {
is_function = true;
}
// x = async function() { await 1 }
Ancestor::AssignmentPatternRight(_) | Ancestor::BindingPatternKind(_) => {
continue;
}
Ancestor::FormalParameterPattern(_) => {
function_in_params = true;
break;
}
_ => {
if is_function {
break;
}
}
}
}
let mut argument = ctx.ast.move_expression(&mut expr.argument);
// When a async function is used as parameter, we don't need to wrap its await expression with awaitAsyncGenerator helper.
// `function example(a = async function b() { await 1 }) {}`
if !function_in_params {
let arguments = ctx.ast.vec1(Argument::from(argument));
argument = self.ctx.helper_call_expr(Helper::AwaitAsyncGenerator, arguments, ctx);
}
let arguments = ctx.ast.vec1(Argument::from(argument));
argument = self.ctx.helper_call_expr(Helper::AwaitAsyncGenerator, arguments, ctx);

Some(ctx.ast.expression_yield(SPAN, false, Some(argument)))
}
}