Skip to content

fix(linter): fix is_method_call with parentheses and chain expression #7095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Nov 4, 2024
Merged

fix(linter): fix is_method_call with parentheses and chain expression #7095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
310dc5c
fix is_method_call even with parentheses and chain
tbashiyy Nov 3, 2024
b6f735b
add test case
tbashiyy Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/oxc_linter/src/ast_util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,14 @@ pub fn is_method_call<'a>(
}
}

let Some(member_expr) = call_expr.callee.without_parentheses().as_member_expression() else {
return false;
let callee_without_parentheses = call_expr.callee.without_parentheses();
let member_expr = match callee_without_parentheses {
match_member_expression!(Expression) => callee_without_parentheses.to_member_expression(),
Expression::ChainExpression(chain) => match chain.expression {
match_member_expression!(ChainElement) => chain.expression.to_member_expression(),
ChainElement::CallExpression(_) => return false,
},
_ => return false,
};

if let Some(objects) = objects {
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules/unicorn/prefer_array_flat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ fn test() {
r"array.flatMap(() => x)",
r"array.flatMap((x, y) => x)",
r"array.flatMap(x => y)",
r"(array?.flatMap)?.(x => y)",
r"new array.reduce((a, b) => a.concat(b), [])",
r"array.reduce",
r"reduce((a, b) => a.concat(b), [])",
Expand Down Expand Up @@ -388,6 +389,7 @@ fn test() {

let fail = vec![
r"array.flatMap(x => x)",
r"(array?.flatMap)?.(x => x)",
r"function foo(){return[].flatMap(x => x)}",
r"foo.flatMap(x => x) instanceof Array",
r"array.reduce((a, b) => a.concat(b), [])",
Expand Down
9 changes: 9 additions & 0 deletions crates/oxc_linter/src/snapshots/prefer_array_flat.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
---
source: crates/oxc_linter/src/tester.rs
assertion_line: 353
snapshot_kind: text
---
⚠ eslint-plugin-unicorn(prefer-array-flat): Prefer Array#flat() over legacy techniques to flatten arrays.
╭─[prefer_array_flat.tsx:1:1]
Expand All @@ -8,6 +10,13 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Call `.flat()` on the array instead.

⚠ eslint-plugin-unicorn(prefer-array-flat): Prefer Array#flat() over legacy techniques to flatten arrays.
╭─[prefer_array_flat.tsx:1:1]
1 │ (array?.flatMap)?.(x => x)
· ──────────────────────────
╰────
help: Call `.flat()` on the array instead.

⚠ eslint-plugin-unicorn(prefer-array-flat): Prefer Array#flat() over legacy techniques to flatten arrays.
╭─[prefer_array_flat.tsx:1:22]
1 │ function foo(){return[].flatMap(x => x)}
Expand Down