Skip to content

refactor(linter): remove unused CLI result types #7088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 2, 2024
Merged

refactor(linter): remove unused CLI result types #7088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions apps/oxlint/src/result.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ pub enum CliRunResult {
error: String,
},
LintResult(LintResult),
FormatResult(FormatResult),
TypeCheckResult {
duration: Duration,
number_of_diagnostics: usize,
},
PrintConfigResult {
config_file: String,
},
Expand All @@ -50,12 +45,6 @@ pub struct LintResult {
pub print_summary: bool,
}

#[derive(Debug)]
pub struct FormatResult {
pub duration: Duration,
pub number_of_files: usize,
}

impl Termination for CliRunResult {
#[allow(clippy::print_stdout, clippy::print_stderr)]
fn report(self) -> ExitCode {
Expand Down Expand Up @@ -115,26 +104,6 @@ impl Termination for CliRunResult {
u8::from((number_of_warnings > 0 && deny_warnings) || number_of_errors > 0);
ExitCode::from(exit_code)
}
Self::FormatResult(FormatResult { duration, number_of_files }) => {
let threads = rayon::current_num_threads();
let time = Self::get_execution_time(&duration);
let s = if number_of_files == 1 { "" } else { "s" };
println!(
"Finished in {time} on {number_of_files} file{s} using {threads} threads."
);
ExitCode::from(0)
}
Self::TypeCheckResult { duration, number_of_diagnostics } => {
let time = Self::get_execution_time(&duration);
println!("Finished in {time}.");

if number_of_diagnostics > 0 {
println!("Found {number_of_diagnostics} errors.");
return ExitCode::from(1);
}

ExitCode::from(0)
}
Self::PrintConfigResult { config_file } => {
println!("{config_file}");
ExitCode::from(0)
Expand Down