feat(oxc_language_server): Publish a message when there are UnknownRules errors building the LinterBuilder#7087
Closed
nrayburn-tech wants to merge 1 commit intooxc-project:mainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #7087 will not alter performanceComparing Summary
|
…les errors building the LinterBuilder
nrayburn-tech
force-pushed
the
lsp-publish-unknown-rule-messages
branch
from
32f7bad to
95a5bf2
Compare
Collaborator
Author
|
The unknown rules check was pulled out of main for the 0.11 release. This needs to wait until that is re-added. If it isn’t going to be added back (or added back differently), then this can be closed. |
Collaborator
Author
|
Closing for now since this probably won't be enabled again for a while. #7257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this retains the current CLI behavior of exiting on unknown rules (that's still being discussed, but I figured I should just keep it the same here). This modifies the language server to emit a message to editors which then display a notification within the editor.
Ref #6988