Skip to content

fix(linter): remove confusing help text for now#7081

Merged
Boshen merged 1 commit intomainfrom
11-01-fix_linter_remove_confusing_help_text_for_now
Nov 2, 2024
Merged

fix(linter): remove confusing help text for now#7081
Boshen merged 1 commit intomainfrom
11-01-fix_linter_remove_confusing_help_text_for_now

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Nov 1, 2024

It's possible that the rule may not exist at all, or it's part of a disabled plugin. The help text doesn't give a clue as to which is the case currently, so it's probably less confusing to just omit it completely.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Nov 1, 2024
@camchenry camchenry force-pushed the 11-01-fix_linter_remove_confusing_help_text_for_now branch from 1baba6e to dd895dc Compare November 1, 2024 22:14
@camchenry camchenry marked this pull request as ready for review November 1, 2024 22:15
@Boshen Boshen merged commit 38d1f78 into main Nov 2, 2024
@Boshen Boshen deleted the 11-01-fix_linter_remove_confusing_help_text_for_now branch November 2, 2024 03:50
@oxc-bot oxc-bot mentioned this pull request Nov 3, 2024
Boshen added a commit that referenced this pull request Nov 3, 2024
## [0.11.0] - 2024-11-03

- 9fd9f4f linter: [**BREAKING**] Sync sindresorhus/globals; removed
Object.prototype properties from builtin and es* globals (#6991)
(Boshen)

### Features

- 6b619da editor: Listen to config file changes and trigger a
didChangeConfiguration update (#6964) (Nicholas Rayburn)
- 7872927 editor/vscode: Support window/showMessage event (#7085)
(Nicholas Rayburn)
- 2184588 linter: Do not bail for unmatched rules yet (#7093) (Boshen)
- a6fcd81 linter: Add `import/no-commonjs` rule (#6978) (Dmitry
Zakharov)
- 1691cab linter: Support user-configurable secrets for
`oxc-security/api-keys` (#5938) (DonIsaac)
- 610621c linter: Implement `react/style-prop-object` (#6342) (Albert
Kaaman)
- 1e2f012 linter: Add `oxc/no-map-spread` (#6751) (DonIsaac)
- 1c66473 linter: Implement `eslint/prefer-object-has-own` (#6905)
(tomoya yanagibashi)

### Bug Fixes

- ebf3753 editor: Fix onConfigChange to send the correct config for
didChangeConfiguration notification (#6962) (Nicholas Rayburn)
- 79bf74a linter: Check is_reference_to_global_variable in
`no-array-constructor` (#7067) (Naoya Yoshizawa)
- 38d1f78 linter: Remove confusing help text for now (#7081) (Cam
McHenry)
- 147e2e4 linter: Allow replacing rule when none are enabled yet (#7014)
(camchenry)
- 7aa496a linter: Remove unsafe fixer of `no-useless-spread` (#6655)
(dalaoshu)
- f5a7134 linter/no-unused-vars: False positive for discarded reads
within sequences (#6907) (DonIsaac)

### Documentation

- 4551baa linter: Document `rules` (#6983) (Boshen)

### Refactor

- a8dc75d linter: Remove unused CLI result types (#7088) (camchenry)
- 8f1460e linter: Move `LintPlugins` from `LintOptions` to `LintConfig`
(#6932) (DonIsaac)

### Testing

- c35d3f2 linter: Improve test failure output (#6975) (camchenry)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants