Skip to content

refactor(traverse): do not use AstBuilder::*_from_* methods #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 2, 2024
Merged

refactor(traverse): do not use AstBuilder::*_from_* methods #7069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/oxc_traverse/src/context/bound_identifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
use oxc_ast::{
ast::{AssignmentTarget, BindingIdentifier, BindingPattern, Expression, IdentifierReference},
ast::{
AssignmentTarget, BindingIdentifier, BindingPattern, BindingPatternKind, Expression,
IdentifierReference,
},
NONE,
};
use oxc_span::{Atom, Span, SPAN};
Expand Down Expand Up @@ -60,7 +63,7 @@ impl<'a> BoundIdentifier<'a> {
/// Create `BindingPattern` for this binding
pub fn create_binding_pattern(&self, ctx: &TraverseCtx<'a>) -> BindingPattern<'a> {
let ident = self.create_binding_identifier(ctx);
let binding_pattern_kind = ctx.ast.binding_pattern_kind_from_binding_identifier(ident);
let binding_pattern_kind = BindingPatternKind::BindingIdentifier(ctx.alloc(ident));
ctx.ast.binding_pattern(binding_pattern_kind, NONE, false)
}

Expand Down Expand Up @@ -238,7 +241,7 @@ impl<'a> BoundIdentifier<'a> {
ctx: &mut TraverseCtx<'a>,
) -> Expression<'a> {
let ident = self.create_spanned_reference(span, flags, ctx);
ctx.ast.expression_from_identifier_reference(ident)
Expression::Identifier(ctx.alloc(ident))
}

/// Create `Expression::Identifier` referencing this binding, with specified `Span` and `ReferenceFlags`
Expand All @@ -249,6 +252,6 @@ impl<'a> BoundIdentifier<'a> {
ctx: &mut TraverseCtx<'a>,
) -> AssignmentTarget<'a> {
let ident = self.create_spanned_reference(span, flags, ctx);
AssignmentTarget::from(ctx.ast.simple_assignment_target_from_identifier_reference(ident))
AssignmentTarget::AssignmentTargetIdentifier(ctx.alloc(ident))
}
}