Skip to content

fix(linter): check is_reference_to_global_variable in no-array-constructor rule #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 3 commits into from
Nov 2, 2024
Merged

fix(linter): check is_reference_to_global_variable in no-array-constructor rule #7067

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2061192
check is_reference_to_global_variable on no-array-constructor
azihsoyn Nov 1, 2024
90edd36
Update crates/oxc_linter/src/rules/eslint/no_array_constructor.rs
azihsoyn Nov 2, 2024
ac35515
fix reference
azihsoyn Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_array_constructor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
use oxc_ast::ast::Expression;
use oxc_ast::AstKind;
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_semantic::IsGlobalReference;
use oxc_span::Span;

use crate::{context::LintContext, rule::Rule, AstNode};
Expand Down Expand Up @@ -62,10 +64,16 @@ impl Rule for NoArrayConstructor {
&new_expr.type_parameters,
false,
),
_ => return,
_ => {
return;
}
};

if callee.is_specific_id("Array")
let Expression::Identifier(ident) = &callee else {
return;
};

if ident.is_global_reference_name("Array", ctx.symbols())
&& arguments.len() != 1
&& type_parameters.is_none()
&& !optional
Expand Down Expand Up @@ -104,6 +112,7 @@ fn test() {
("Array?.<Foo>();", None),
("Array?.(0, 1, 2);", None),
("Array?.(x, y);", None),
("var Array; new Array;", None),
];

let fail = vec![
Expand Down