Skip to content

test(linter): improve test failure output #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 28, 2024
Merged

test(linter): improve test failure output #6975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions crates/oxc_linter/src/tester.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,17 +356,44 @@ impl Tester {

fn test_pass(&mut self) {
for TestCase { source, rule_config, eslint_config, path } in self.expect_pass.clone() {
let result = self.run(&source, rule_config, &eslint_config, path, ExpectFixKind::None);
let result =
self.run(&source, rule_config.clone(), &eslint_config, path, ExpectFixKind::None);
let passed = result == TestResult::Passed;
assert!(passed, "expect test to pass: {source} {}", self.snapshot);
let config = rule_config.map_or_else(
|| "\n\n------------------------\n".to_string(),
|v| {
format!(
"\n-------- rule config --------\n{}",
serde_json::to_string_pretty(&v).unwrap()
)
},
);
assert!(
passed,
"expected test to pass, but it failed:\n\n-------- source --------\n\n{source}\n\n-------- error --------\n{}{config}\n",
self.snapshot
);
}
}

fn test_fail(&mut self) {
for TestCase { source, rule_config, eslint_config, path } in self.expect_fail.clone() {
let result = self.run(&source, rule_config, &eslint_config, path, ExpectFixKind::None);
let result =
self.run(&source, rule_config.clone(), &eslint_config, path, ExpectFixKind::None);
let failed = result == TestResult::Failed;
assert!(failed, "expect test to fail: {source}");
let config = rule_config.map_or_else(
|| "\n\n------------------------".to_string(),
|v| {
format!(
"\n-------- rule config --------\n{}",
serde_json::to_string_pretty(&v).unwrap()
)
},
);
assert!(
failed,
"expected test to fail, but it passed:\n\n-------- source --------\n\n{source}{config}\n",
);
}
}

Expand Down