Skip to content

refactor(ast_tools): hardcode schema output path #6949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 27, 2024
Merged

refactor(ast_tools): hardcode schema output path #6949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tasks/ast_tools/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ static SOURCE_PATHS: &[&str] = &[
const AST_CRATE: &str = "crates/oxc_ast";
const TYPESCRIPT_PACKAGE: &str = "npm/oxc-types";
const GITHUB_WATCH_LIST_PATH: &str = ".github/.generated_ast_watch_list.yml";
const SCHEMA_PATH: &str = "schema.json";

type Result<R> = std::result::Result<R, String>;
type TypeId = usize;
Expand All @@ -57,8 +58,8 @@ pub struct CliOptions {
dry_run: bool,
/// Prints no logs.
quiet: bool,
/// Path of output `schema.json`.
schema: Option<std::path::PathBuf>,
/// Output JSON schema.
schema: bool,
}

fn main() -> std::result::Result<(), Box<dyn std::error::Error>> {
Expand Down Expand Up @@ -95,9 +96,9 @@ fn main() -> std::result::Result<(), Box<dyn std::error::Error>> {
}
}

if let CliOptions { schema: Some(schema_path), dry_run: false, .. } = cli_options {
if let CliOptions { schema: true, dry_run: false, .. } = cli_options {
let schema = serde_json::to_string_pretty(&schema.defs).normalize()?;
write_all_to(schema.as_bytes(), schema_path)?;
write_all_to(schema.as_bytes(), SCHEMA_PATH)?;
}

Ok(())
Expand Down