Skip to content

Comments

fix(minifier): do not dce object literals yet#6839

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-24-fix_minifier_do_not_dce_object_literals_yet
Oct 24, 2024
Merged

fix(minifier): do not dce object literals yet#6839
graphite-app[bot] merged 1 commit intomainfrom
10-24-fix_minifier_do_not_dce_object_literals_yet

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 24, 2024

closes #6769

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Oct 24, 2024
Copy link
Member Author

Boshen commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 24, 2024

CodSpeed Performance Report

Merging #6839 will not alter performance

Comparing 10-24-fix_minifier_do_not_dce_object_literals_yet (ca79993) with main (3923e63)

Summary

✅ 30 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Merge activity

@Boshen Boshen force-pushed the 10-24-fix_minifier_do_not_dce_object_literals_yet branch from e8aac6f to ca79993 Compare October 24, 2024 01:05
@graphite-app graphite-app bot merged commit ca79993 into main Oct 24, 2024
@graphite-app graphite-app bot deleted the 10-24-fix_minifier_do_not_dce_object_literals_yet branch October 24, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: cannot preserve unknown global reference in property key inside function body

1 participant