refactor(minifier): dereference SymbolId as soon as possible

[overlookmotel]

Style nit. Dereference &SymbolId to SymbolId as early as possible. &SymbolId is 8 bytes, whereas SymbolId is 4 bytes.

In simple cases like these, compiler will optimize it anyway, but still I think it's a better pattern to dererence early. In more complicated cases, it will be better for performance, and in my opinion, it makes things clearer if vars called symbol_id are always a SymbolId, and not sometimes a &SymbolId.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• refactor(minifier): dereference SymbolId as soon as possible #6823 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[overlookmotel]

Small style nit, so merging without review.

[overlookmotel]

Merge activity

• Oct 23, 8:57 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 23, 9:00 AM EDT: A user added this pull request to the Graphite merge queue.
• Oct 23, 9:17 AM EDT: A user merged this pull request with the Graphite merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #6823 will not alter performance

_{Comparing 10-23-refactor_minifier_dereference_symbolid_as_soon_as_possible (e59b5d9) with main (a148023)}

Summary

✅ 30 untouched benchmarks