refactor(linter): dereference IDs as soon as possible#6821
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 23, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
Member
Author
|
Small style nit, so merging without review. |
Member
Author
Merge activity
|
Style nit. Dereference `&ScopeId` to `ScopeId` (and other IDs) as early as possible. `&ScopeId` is 8 bytes, whereas `ScopeId` is 4 bytes. In simple cases like these, compiler will optimize it anyway, but still I think it's a better pattern to dererence early. In more complicated cases, it will be better for performance, and in my opinion, it makes things clearer if vars called `scope_id` are always a `ScopeId`, not sometimes a `&ScopeId`.
overlookmotel
force-pushed
the
10-23-refactor_linter_dereference_ids_as_soon_as_possible
branch
from
c612051 to
a148023
Compare
graphite-app
bot
deleted the
10-23-refactor_linter_dereference_ids_as_soon_as_possible
branch
CodSpeed Performance ReportMerging #6821 will not alter performanceComparing Summary
|
Boshen
added a commit
that referenced
this pull request
Oct 26, 2024
## [0.10.3] - 2024-10-26 - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (#6847) (leaysgur) - 8032813 regular_expression: [**BREAKING**] Migrate to new regexp parser API (#6741) (leaysgur) ### Features - a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (#6781) (Tapan Prakash) - 2aa763c linter: Warn unmatched rule names (#6782) (Tapan Prakash) - 0acca58 linter: Support `--print-config all` to print config file for project (#6579) (mysteryven) ### Bug Fixes - f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs (#6872) (DonIsaac) - 54a5032 linter: Correct false positive in `no-duplicates` (#6748) (dalaoshu) - a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen) ### Documentation - 3923e63 linter: Add schema to config examples (#6838) (Dmitry Zakharov) ### Refactor - a148023 linter: Dereference IDs as soon as possible (#6821) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Orenbek
pushed a commit
to Orenbek/oxc
that referenced
this pull request
Oct 28, 2024
## [0.10.3] - 2024-10-26 - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (oxc-project#6847) (leaysgur) - 8032813 regular_expression: [**BREAKING**] Migrate to new regexp parser API (oxc-project#6741) (leaysgur) ### Features - a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (oxc-project#6781) (Tapan Prakash) - 2aa763c linter: Warn unmatched rule names (oxc-project#6782) (Tapan Prakash) - 0acca58 linter: Support `--print-config all` to print config file for project (oxc-project#6579) (mysteryven) ### Bug Fixes - f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs (oxc-project#6872) (DonIsaac) - 54a5032 linter: Correct false positive in `no-duplicates` (oxc-project#6748) (dalaoshu) - a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen) ### Documentation - 3923e63 linter: Add schema to config examples (oxc-project#6838) (Dmitry Zakharov) ### Refactor - a148023 linter: Dereference IDs as soon as possible (oxc-project#6821) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style nit. Dereference
&ScopeIdtoScopeId(and other IDs) as early as possible.&ScopeIdis 8 bytes, whereasScopeIdis 4 bytes.In simple cases like these, compiler will optimize it anyway, but still I think it's a better pattern to dererence early. In more complicated cases, it will be better for performance, and in my opinion, it makes things clearer if vars called
scope_idare always aScopeId, not sometimes a&ScopeId.