refactor(transformer/react-refresh): dereference ScopeId as soon as possible#6820
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 23, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
github-actions
bot
added
the
C-cleanup
This was referenced Oct 23, 2024
CodSpeed Performance ReportMerging #6820 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
10-23-refactor_transformer_react-refresh_unwrap_bindingidentifier_symbol_id_
branch
from
f276ed6 to
f7c7a23
Compare
overlookmotel
force-pushed
the
10-23-refactor_transformer_react-refresh_dereference_scopeid_as_soon_as_possible
branch
from
05d41fe to
21ec0e0
Compare
Member
Merge activity
|
… possible (#6820) Style nit. Dereference `&ScopeId` to `ScopeId` as early as possible. `&ScopeId` is 8 bytes, whereas `ScopeId` is 4 bytes. In simple cases like this, compiler will optimize it anyway, but still I think it's a better pattern to dererence early. In more complicated cases, it will be better for performance, and in my opinion, it makes things clearer if vars called `scope_id` are always a `ScopeId`, not sometimes a `&ScopeId`.
Dunqing
force-pushed
the
10-23-refactor_transformer_react-refresh_unwrap_bindingidentifier_symbol_id_
branch
from
f7c7a23 to
57685b2
Compare
Dunqing
force-pushed
the
10-23-refactor_transformer_react-refresh_dereference_scopeid_as_soon_as_possible
branch
from
21ec0e0 to
e5f4b4a
Compare
Base automatically changed from
10-23-refactor_transformer_react-refresh_unwrap_bindingidentifier_symbol_id_
to
main
October 23, 2024 13:50
graphite-app
bot
deleted the
10-23-refactor_transformer_react-refresh_dereference_scopeid_as_soon_as_possible
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style nit. Dereference
&ScopeIdtoScopeIdas early as possible.&ScopeIdis 8 bytes, whereasScopeIdis 4 bytes.In simple cases like this, compiler will optimize it anyway, but still I think it's a better pattern to dererence early. In more complicated cases, it will be better for performance, and in my opinion, it makes things clearer if vars called
scope_idare always aScopeId, not sometimes a&ScopeId.