Skip to content

docs(ast): fix comment for ClassElement::r#static #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 22, 2024
Merged

docs(ast): fix comment for ClassElement::r#static #6771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions crates/oxc_ast/src/ast_impl/js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,8 +1344,22 @@ impl<'a> ClassElement<'a> {
matches!(self, Self::StaticBlock(_))
}

/// Returns `true` if this [`ClassElement`] is a property and has a
/// static modifier.
/// Returns `true` if this [`ClassElement`] has a static modifier.
///
/// Note: Class static blocks do not have a "modifier", as there is no non-static equivalent.
/// Therefore, returns `false` for static blocks.
///
/// The following all return `true`:
/// ```ts
/// class {
/// static prop = 1;
/// static method() {}
/// static #private = 2;
/// static #privateMethod() {}
/// static accessor accessorProp = 3;
/// static accessor #privateAccessorProp = 4;
/// }
/// ```
pub fn r#static(&self) -> bool {
match self {
Self::TSIndexSignature(_) | Self::StaticBlock(_) => false,
Expand Down