Skip to content

feat(linter): import/no-cycle should turn on ignore_types by default#6761

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-22-feat_linter_import_no-cycle_should_turn_on_ignore_types_by_default
Oct 22, 2024
Merged

feat(linter): import/no-cycle should turn on ignore_types by default#6761
graphite-app[bot] merged 1 commit intomainfrom
10-22-feat_linter_import_no-cycle_should_turn_on_ignore_types_by_default

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 22, 2024

closes #6759

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 22, 2024
Copy link
Member Author

Boshen commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 22, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Merge activity

@Boshen Boshen force-pushed the 10-22-feat_linter_import_no-cycle_should_turn_on_ignore_types_by_default branch from ac755e2 to dbe1972 Compare October 22, 2024 02:35
@graphite-app graphite-app bot merged commit dbe1972 into main Oct 22, 2024
@graphite-app graphite-app bot deleted the 10-22-feat_linter_import_no-cycle_should_turn_on_ignore_types_by_default branch October 22, 2024 02:39
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #6761 will not alter performance

Comparing 10-22-feat_linter_import_no-cycle_should_turn_on_ignore_types_by_default (dbe1972) with main (8387bac)

Summary

✅ 30 untouched benchmarks

Boshen added a commit that referenced this pull request Oct 22, 2024
## [0.10.2] - 2024-10-22

### Features

- dbe1972 linter: Import/no-cycle should turn on ignore_types by default
(#6761) (Boshen)
- 619d06f linter: Fix suggestion for `eslint:no_empty_static_block` rule
(#6732) (Tapan Prakash)

### Bug Fixes


### Performance

- 8387bac linter: Apply small file optimization, up to 30% faster
(#6600) (camchenry)

### Refactor

- b884577 linter: All ast_util functions take Semantic (#6753)
(DonIsaac)
- 744aa74 linter: Impl `Deref<Target = Semantic>` for `LintContext`
(#6752) (DonIsaac)
- 6ffdcc0 oxlint: Lint/mod.rs -> lint.rs (#6746) (Boshen)

### Testing

- b03cec6 oxlint: Add `--fix` test case (#6747) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(linter): import/no-cycle should turn on ignore_types by default

1 participant