Skip to content

Comments

refactor(transformer): rename OxcVec to AVec#6737

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-21-refactor_transformer_rename_oxcvec_to_avec_
Oct 21, 2024
Merged

refactor(transformer): rename OxcVec to AVec#6737
graphite-app[bot] merged 1 commit intomainfrom
10-21-refactor_transformer_rename_oxcvec_to_avec_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 21, 2024

use oxc_allocator::Vec as AVec as per naming convention suggested in #6996

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Oct 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 21, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 21, 2024 11:09
@overlookmotel overlookmotel requested a review from Dunqing October 21, 2024 11:09
@overlookmotel
Copy link
Member Author

@Dunqing I don't know what you think of AVec? Is it too mysterious? Maybe AstVec would be better? I don't really mind what name we choose, but I think most important thing is to be consistent.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6737 will not alter performance

Comparing 10-21-refactor_transformer_rename_oxcvec_to_avec_ (06e06e3) with main (7fbca9d)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Merge activity

Dunqing pushed a commit that referenced this pull request Oct 21, 2024
@Dunqing Dunqing force-pushed the 10-21-refactor_transformer_rename_oxcvec_to_avec_ branch from a5d44f4 to 64bd821 Compare October 21, 2024 11:44
@Dunqing Dunqing force-pushed the 10-21-refactor_transformer_rename_oxcvec_to_avec_ branch from 64bd821 to 06e06e3 Compare October 21, 2024 11:46
@graphite-app graphite-app bot merged commit 06e06e3 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the 10-21-refactor_transformer_rename_oxcvec_to_avec_ branch October 21, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants