Skip to content

refactor(codegen): rename vars in CodeBuffer methods #6506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 13, 2024
Merged

refactor(codegen): rename vars in CodeBuffer methods #6506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions crates/oxc_codegen/src/code_buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ impl CodeBuffer {
/// Push a single ASCII byte into the buffer.
///
/// # Panics
/// If `b` is not an ASCII byte (`0 - 0x7F`).
/// If `byte` is not an ASCII byte (`0 - 0x7F`).
///
/// # Example
/// ```
Expand All @@ -153,12 +153,12 @@ impl CodeBuffer {
/// assert_eq!(source, "foo");
/// ```
#[inline]
pub fn print_ascii_byte(&mut self, b: u8) {
pub fn print_ascii_byte(&mut self, byte: u8) {
// NOTE: since this method is inlined, this assertion should get
// optimized away by the compiler when the value of `b` is known,
// optimized away by the compiler when the value of `byte` is known,
// e.g. when printing a constant.
assert!(b.is_ascii(), "byte {b} is not ASCII");
self.buf.push(b);
assert!(byte.is_ascii(), "byte {byte} is not ASCII");
self.buf.push(byte);
}

/// Push a byte to the buffer, without checking that the buffer still represents a valid
Expand Down Expand Up @@ -201,8 +201,8 @@ impl CodeBuffer {
/// [`take_source_text`]: CodeBuffer::take_source_text
/// [`print_unchecked`]: CodeBuffer::print_unchecked
#[inline]
pub unsafe fn print_byte_unchecked(&mut self, ch: u8) {
self.buf.push(ch);
pub unsafe fn print_byte_unchecked(&mut self, byte: u8) {
self.buf.push(byte);
}

/// Push a single Unicode character into the buffer.
Expand Down