ci(transformer): move post-transform checker to tasks crate#6288
Merged
graphite-app[bot] merged 1 commit intomainfrom Oct 5, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This was referenced Oct 5, 2024
CodSpeed Performance ReportMerging #6288 will not alter performanceComparing Summary
|
1723b84 to
bff3151
Compare
2019ad0 to
466bb0b
Compare
This was referenced Oct 5, 2024
Contributor
Merge activity
|
Move post-transform checker into a `tasks` crate. It doesn't feel like it belongs in `oxc_semantic`. It also feels like too heavy a lump of code to put in `tasks/common`.
bff3151 to
d4f2ee9
Compare
466bb0b to
e19deaa
Compare
Base automatically changed from
10-05-test_transformer_tidy_up_transform_checker
to
main
October 5, 2024 14:54
This was referenced Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Move post-transform checker into a
taskscrate. It doesn't feel like it belongs inoxc_semantic. It also feels like too heavy a lump of code to put intasks/common.