Skip to content

Comments

fix(transform): ensure consistent naming for ES2015BindingOptions in index.d.ts#6255

Closed
shulaoda wants to merge 2 commits intooxc-project:mainfrom
shulaoda:fix/type-es2015-binding-options
Closed

fix(transform): ensure consistent naming for ES2015BindingOptions in index.d.ts#6255
shulaoda wants to merge 2 commits intooxc-project:mainfrom
shulaoda:fix/type-es2015-binding-options

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Oct 2, 2024

closes #6254

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2024

CodSpeed Performance Report

Merging #6255 will not alter performance

Comparing shulaoda:fix/type-es2015-binding-options (49019aa) with main (f98e12c)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen self-assigned this Oct 3, 2024
Boshen added a commit that referenced this pull request Oct 3, 2024
@graphite-app graphite-app bot closed this in 099ff3a Oct 3, 2024
@shulaoda shulaoda deleted the fix/type-es2015-binding-options branch October 3, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

napi/transform: ts declaration file - incorrect Es2015BindingOptions interface name

2 participants