test(minifier): add variable collapsing test cases#6227
Closed
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
DonIsaac
force-pushed
the
don/10-01-fix_minifier_collapse_variables_when_join_vars_option_is_true
branch
from
2b9838c to
ea896ec
Compare
DonIsaac
force-pushed
the
don/10-01-test_minifier_add_variable_collapsing_test_cases
branch
from
e7967f0 to
69779a1
Compare
CodSpeed Performance ReportMerging #6227 will not alter performanceComparing Summary
|
DonIsaac
force-pushed
the
don/10-01-test_minifier_add_variable_collapsing_test_cases
branch
from
69779a1 to
3d03f87
Compare
Contributor
Boshen
pushed a commit
that referenced
this pull request
Oct 10, 2024
…s` (#6421) closes #6227 I noticed that the implementation of `collapse-variable-declarations` seems incomplete and appears quite simple. Therefore, I would like to quickly add all the test cases to work on this. Previously, I saw that `DonIsaac` had also submitted a related PR, but he might have been too busy to respond for a long time. I want to apologize for closing his PR.
Boshen
deleted the
don/10-01-test_minifier_add_variable_collapsing_test_cases
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test cases for the variable declaration collapsing AST pass