Skip to content

feat(minifier): minify unary plus negation.#6201

Closed
7086cmd wants to merge 5 commits intooxc-project:mainfrom
7086cmd:feat/minifier-unary-plus-minus
Closed

feat(minifier): minify unary plus negation.#6201
7086cmd wants to merge 5 commits intooxc-project:mainfrom
7086cmd:feat/minifier-unary-plus-minus

Conversation

@7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Oct 1, 2024

It is uncertain whether this applies to other situations, so let us eliminate it in negation first, and after I have conducted a comprehensive investigation of the Closure Compiler, we can make a definitive decision.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-minifier Area - Minifier label Oct 1, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #6201 will not alter performance

Comparing 7086cmd:feat/minifier-unary-plus-minus (833407d) with main (7a381ee)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 1, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2024

Merge activity

  • Oct 1, 12:53 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 1, 12:53 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Oct 1, 12:53 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 1, 2024
@7086cmd 7086cmd closed this Oct 1, 2024
Boshen pushed a commit that referenced this pull request Oct 1, 2024
resolves #6201.
It is uncertain whether this applies to other situations, so let us eliminate it in negation first, and after I have conducted a comprehensive investigation of the Closure Compiler, we can make a definitive decision.
@7086cmd 7086cmd deleted the feat/minifier-unary-plus-minus branch October 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants