Skip to content

test(linter): add more test cases for disable directives #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 24, 2024
Merged

test(linter): add more test cases for disable directives #6047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 140 additions & 0 deletions crates/oxc_linter/src/disable_directives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,84 @@ fn test() {
debugger;
"
),
// Handles no spaces in comment
format!(
"debugger; //{prefix}-disable-line
debugger; //{prefix}-disable-line

//{prefix}-disable-next-line
debugger;

/*{prefix}-disable-next-line*/
debugger;

debugger; /*{prefix}-disable-line*/

debugger; //{prefix}-disable-line no-debugger

//{prefix}-disable-next-line no-debugger
debugger;

debugger; /*{prefix}-disable-line no-debugger*/

/*{prefix}-disable-next-line no-debugger*/
debugger;
"
),
// Handles extra spaces in comment
format!(
"debugger; // {prefix}-disable-line
debugger; // \t\t {prefix}-disable-line

// {prefix}-disable-next-line
debugger;

/* {prefix}-disable-next-line */
debugger;

debugger; /* {prefix}-disable-line */

debugger; // {prefix}-disable-line no-debugger

// {prefix}-disable-next-line no-debugger
debugger;

debugger; /* \t {prefix}-disable-line no-debugger*/

/* \t {prefix}-disable-next-line no-debugger */
debugger;
"
),
// Extra commas
format!(
"
debugger // {prefix}-disable-line no-debugger,
debugger // {prefix}-disable-line ,no-debugger
debugger // {prefix}-disable-line no-debugger,,
debugger // {prefix}-disable-line ,,no-debugger,,
debugger // {prefix}-disable-line ,,no-debugger,,semi,,
debugger // {prefix}-disable-line ,,no-debugger,,no-debugger,,
debugger // {prefix}-disable-line , , ,,no-debugger, , ,

// {prefix}-disable-next-line no-debugger,
debugger
// {prefix}-disable-next-line ,no-debugger,
debugger
// {prefix}-disable-next-line no-debugger,,
debugger
// {prefix}-disable-next-line ,,no-debugger,,
debugger
// {prefix}-disable-next-line ,,no-debugger,,semi,,
debugger
// {prefix}-disable-next-line ,,no-debugger,,no-debugger,,
debugger
// {prefix}-disable-next-line , , ,,no-debugger, , ,
"
),
format!("
/* {prefix}-disable , ,no-debugger, , */
debugger;
")
];

let fail = vec![
Expand Down Expand Up @@ -470,6 +548,68 @@ fn test() {
debugger;
"
),
// Handles no spaces in comment
format!(
"
/*{prefix}-disable*/
debugger;
/*{prefix}-enable*/
debugger;
"
),
format!(
"
/*{prefix}-disable no-debugger,no-console*/
debugger;
/*{prefix}-enable no-debugger,no-console*/
debugger;
"
),
format!(
"debugger; //{prefix}-disable-line no-alert,quotes,semi
//{prefix}-disable-next-line no-alert,quotes,semi
debugger;
debugger; /*{prefix}-disable-line no-alert,quotes,semi */
/*{prefix}-disable-next-line no-alert,quotes,semi */
debugger;
/*{prefix}-disable-next-line
no-alert,
quotes,
semi*/
debugger;
"
),
// Handles extra spaces in comment
format!(
"
/* \t\t {prefix}-disable \t\t*/
debugger;
/* \t\t {prefix}-enable \t\t*/
debugger;
"
),
format!(
"
/* \t\t {prefix}-disable \t\t no-debugger, \t\t no-console \t\t */
debugger;
/* \t\t {prefix}-enable \t\t no-debugger, \t\t no-console \t\t */
debugger;
"
),
format!(
"debugger; // \t\t {prefix}-disable-line \t\t no-alert, \t\t quotes, \t\t semi \t\t
// \t\t {prefix}-disable-next-line \t\t no-alert, \t\t quotes, \t\t semi
debugger;
debugger; /* \t\t {prefix}-disable-line \t\t no-alert, \t\t quotes, \t\t semi \t\t */
/* \t\t {prefix}-disable-next-line \t\t no-alert, \t\t quotes, \t\t semi */
debugger;
/* \t\t {prefix}-disable-next-line
\t\t no-alert, \t\t
\t\t quotes, \t\t
\t\t semi \t\t */
debugger;
"
),
];

Tester::new("no-debugger", pass, fail).test();
Expand Down