Skip to content

test(linter): import test cases for no-empty-character-class #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 23, 2024
Merged

test(linter): import test cases for no-empty-character-class #5981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions crates/oxc_linter/src/rules/eslint/no_empty_character_class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ fn test() {
("var foo = /[\\]]/s;", None),
("var foo = /[\\]]/d;", None),
("var foo = /\\[]/", None),
// ES2024
("var foo = /[[^]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[\\]]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[\\[]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[a--b]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[a&&b]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[a][b]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[\\q{}]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[^]--\\p{ASCII}]/v;", None), // { "ecmaVersion": 2024 }
];

let fail = vec![
Expand All @@ -143,6 +152,16 @@ fn test() {
("var foo = /[]]/d;", None),
("var foo = /[[][]]/v;", None),
("var foo = /[[]]|[]/v;", None),
("var foo = /[(]\\u{0}*[]/u;", None), // { "ecmaVersion": 2015 }
// ES2024
("var foo = /[]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[a][]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[a[[b[]c]]d]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[a--[]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[]--b]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[a&&[]]/v;", None), // { "ecmaVersion": 2024 }
("var foo = /[[]&&b]/v;", None), // { "ecmaVersion": 2024 }
];

Tester::new(NoEmptyCharacterClass::NAME, pass, fail).test_and_snapshot();
Expand Down
63 changes: 63 additions & 0 deletions crates/oxc_linter/src/snapshots/no_empty_character_class.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,66 @@ source: crates/oxc_linter/src/tester.rs
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:21]
1 │ var foo = /[(]\u{0}*[]/u;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:12]
1 │ var foo = /[]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:13]
1 │ var foo = /[[]]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:16]
1 │ var foo = /[[a][]]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:17]
1 │ var foo = /[a[[b[]c]]d]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:16]
1 │ var foo = /[a--[]]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:13]
1 │ var foo = /[[]--b]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:16]
1 │ var foo = /[a&&[]]/v;
· ──
╰────
help: Remove the empty character class: `[]`

⚠ eslint(no-empty-character-class): Empty character class will not match anything
╭─[no_empty_character_class.tsx:1:13]
1 │ var foo = /[[]&&b]/v;
· ──
╰────
help: Remove the empty character class: `[]`