Skip to content

refactor(minifier): move dce conditional expression to RemoveDeadCode#5971

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_
Sep 23, 2024
Merged

refactor(minifier): move dce conditional expression to RemoveDeadCode#5971
graphite-app[bot] merged 1 commit intomainfrom
09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Sep 22, 2024

This is aligned to closure compiler

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-minifier Area - Minifier label Sep 22, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2024

CodSpeed Performance Report

Merging #5971 will degrade performances by 16.91%

Comparing 09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_ (0a2f687) with main (860f108)

Summary

❌ 3 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_ Change
minifier[antd.js] 383.6 ms 461.7 ms -16.91%
minifier[react.development.js] 3.8 ms 4.3 ms -11.6%
minifier[typescript.js] 687.9 ms 826.3 ms -16.75%

@Boshen Boshen marked this pull request as draft September 22, 2024 16:15
@Boshen Boshen force-pushed the 09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_ branch from e561e17 to 227703f Compare September 23, 2024 08:44
@Boshen Boshen marked this pull request as ready for review September 23, 2024 08:45
@Boshen Boshen force-pushed the 09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_ branch from 227703f to cdc6ce5 Compare September 23, 2024 08:59
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 23, 2024

Merge activity

  • Sep 23, 6:21 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 6:21 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 23, 6:26 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_ branch from cdc6ce5 to 0a2f687 Compare September 23, 2024 10:22
@graphite-app graphite-app bot merged commit 0a2f687 into main Sep 23, 2024
@graphite-app graphite-app bot deleted the 09-22-refactor_minifier_move_dce_conditional_expression_to_removedeadcode_ branch September 23, 2024 10:26
Boshen added a commit that referenced this pull request Sep 24, 2024
## [0.30.1] - 2024-09-24

### Features

- 5c323a2 minifier: Loop compressor passes (#6013) (Boshen)

### Bug Fixes

- 9ca202a codegen: Preserve newlines between comments (#6014) (Boshen)
- 4a99372 codegen: Print jsdoc comments for `TSEnumMember`s (#6007)
(camc314)
- 97a2c41 isolated-declarations: False positive for class private getter
with non-inferrable return type (#5987) (michaelm)

### Performance

- 2b17003 linter, prettier, diagnostics: Use `FxHashMap` instead of
`std::collections::HashMap` (#5993) (camchenry)
- 7b90d79 transformer: `SparseStack` always keep minimum 1 entry (#5962)
(overlookmotel)
- 28fe80a transformer: Logical assignment operator transform use
`SparseStack` (#5960) (overlookmotel)
- 9f7d4b7 transformer: Exponentiation operator transform use
`SparseStack` (#5959) (overlookmotel)
- 5dc0154 transformer: Nullish coalescing operator transform use
`SparseStack` (#5942) (overlookmotel)
- 618e89e transformer: Arrow function transform: reduce stack memory
usage (#5940) (overlookmotel)

### Documentation

- 5a0d17c ast: Document more AST nodes (#6000) (DonIsaac)
- 18371dd oxc: Include feature-guarded modules in docs.rs (#6012)
(DonIsaac)
- 1abfe8f semantic: Document `SymbolTable` (#5998) (DonIsaac)
- f5eee72 semantic: Correct docs for `Reference` (#5992) (overlookmotel)
- 860f108 transformer: Add to arrow functions transform docs (#5989)
(overlookmotel)

### Refactor

- 0a2f687 minifier: Move dce conditional expression to `RemoveDeadCode`
(#5971) (Boshen)
- f02bf51 transformer: Arrow function transform: remove unnecessary
assertion (#6002) (overlookmotel)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant