Skip to content

refactor(transformer): arrow functions transform do not wrap function expressions in parentheses #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 17, 2024
Merged

refactor(transformer): arrow functions transform do not wrap function expressions in parentheses #5824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions crates/oxc_transformer/src/es2015/arrow_functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,12 @@ impl<'a> Traverse<'a> for ArrowFunctions<'a> {

/// ```ts
/// function a(){
/// () => console.log(this);
/// return () => console.log(this);
/// }
/// // to
/// function a(){
/// var _this = this;
/// (function() { return console.log(_this); });
/// return function() { return console.log(_this); };
/// }
/// ```
/// Insert the var _this = this; statement outside the arrow function
Expand Down Expand Up @@ -306,10 +306,7 @@ impl<'a> ArrowFunctions<'a> {
);
new_function.scope_id.set(scope_id);

let expr = Expression::FunctionExpression(self.ctx.ast.alloc(new_function));
// Avoid creating a function declaration.
// `() => {};` => `(function () {});`
self.ctx.ast.expression_parenthesized(SPAN, expr)
Expression::FunctionExpression(self.ctx.ast.alloc(new_function))
}

/// Insert `var _this = this;` at the top of the statements.
Expand Down