Skip to content

perf(linter): shrink size of DisableDirectives #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 16, 2024
Merged

perf(linter): shrink size of DisableDirectives #5798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/oxc_linter/src/disable_directives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ pub struct DisableDirectives<'a> {
/// All the disabled rules with their corresponding covering spans
intervals: Lapper<u32, DisabledRule<'a>>,
/// Spans of comments that disable all rules
disable_all_comments: Vec<Span>,
disable_all_comments: Box<[Span]>,
/// All comments that disable one or more specific rules
disable_rule_comments: Vec<DisableRuleComment<'a>>,
disable_rule_comments: Box<[DisableRuleComment<'a>]>,
}

impl<'a> DisableDirectives<'a> {
Expand All @@ -38,11 +38,11 @@ impl<'a> DisableDirectives<'a> {
})
}

pub fn disable_all_comments(&self) -> &Vec<Span> {
pub fn disable_all_comments(&self) -> &[Span] {
&self.disable_all_comments
}

pub fn disable_rule_comments(&self) -> &Vec<DisableRuleComment<'a>> {
pub fn disable_rule_comments(&self) -> &[DisableRuleComment<'a>] {
&self.disable_rule_comments
}
}
Expand Down Expand Up @@ -79,8 +79,8 @@ impl<'a> DisableDirectivesBuilder<'a> {
self.build_impl();
DisableDirectives {
intervals: self.intervals,
disable_all_comments: self.disable_all_comments,
disable_rule_comments: self.disable_rule_comments,
disable_all_comments: self.disable_all_comments.into_boxed_slice(),
disable_rule_comments: self.disable_rule_comments.into_boxed_slice(),
}
}

Expand Down