refactor(semantic)!: rename AstNode to Node and AstNodes to Nodes

[overlookmotel]

#5740 renamed AstNodeId to NodeId. To match this, also rename:

• AstNode -> Node
• AstNodes -> Nodes

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• refactor(semantic)!: rename AstNode to Node and AstNodes to Nodes #5767 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[overlookmotel]

@Boshen I think it makes sense for consistency, but is it a step too far?

[codspeed-hq]

CodSpeed Performance Report

Merging #5767 will not alter performance

_{Comparing 09-13-refactor_semantic_rename_astnode_to_node_and_astnodes_to_nodes_ (e7efaff) with main (aac8316)}

Summary

✅ 29 untouched benchmarks

[overlookmotel]

I changed my mind. I don't think this is a good idea. We also have AstKind and AstType, which we don't want to rename to just Kind and Type, so Ast* is going to remain a thing.

We plan to remove the AstNode type anyway as part of #5689. Once that's done, we could rename AstNodes to Nodes.