feat(transformer): enable the react refresh plugin in enable_all by Dunqing · Pull Request #5630 · oxc-project/oxc

Dunqing · 2024-09-09T02:45:28Z

No description provided.

graphite-app · 2024-09-09T02:45:32Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-09-09T02:45:43Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

codspeed-hq · 2024-09-09T16:05:59Z

CodSpeed Performance Report

Merging #5630 will degrade performances by 42.9%

_{Comparing 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all (95a6d99) with main (b8f8dd6)}

Summary

❌ 5 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`main`	`09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all`	Change
❌	`transformer[RadixUIAdoptionSection.jsx]`	163.8 µs	175.1 µs	-6.46%
❌	`transformer[antd.js]`	31.5 ms	55.2 ms	-42.9%
❌	`transformer[cal.com.tsx]`	23.8 ms	33.1 ms	-28.16%
❌	`transformer[checker.ts]`	16.7 ms	21.5 ms	-22.35%
❌	`transformer[pdf.mjs]`	6.4 ms	8 ms	-20.12%

Dunqing · 2024-09-10T03:33:47Z

~~There is another 100x 🥲. I will improve this before this PR~~

Optimize by #5626

graphite-app · 2024-09-11T07:56:59Z

Merge activity

Sep 11, 3:56 AM EDT: Boshen added this pull request to the Graphite merge queue.
Sep 11, 4:08 AM EDT: Boshen merged this pull request with the Graphite merge queue.

## [0.28.0] - 2024-09-11 - afc4548 ast: [**BREAKING**] Educe byte size of `TaggedTemplateExpression::quasi` by `Boxing` it (#5679) (Boshen) - 7415e85 ast: [**BREAKING**] Reduce byte size of `TSImportType::attributes` by `Box`ing it (#5678) (Boshen) - ee4fb42 ast: [**BREAKING**] Reduce size of `WithClause` by `Box`ing it (#5677) (Boshen) - 1fa3e56 semantic: [**BREAKING**] Rename `SymbolTable::iter` to `symbol_ids` (#5621) (overlookmotel) - 96a1552 semantic: [**BREAKING**] Remove `SymbolTable::iter_rev` (#5620) (overlookmotel) - 4a8aec1 span: [**BREAKING**] Change `SourceType::js` to `SourceType::cjs` and `SourceType::mjs` (#5606) (Boshen) - 603817b oxc: [**BREAKING**] Add `SourceType::Unambiguous`; parse `.js` as unambiguous (#5557) (Boshen) - b060525 semantic: [**BREAKING**] Remove `source_type` argument from `SemanticBuilder::new` (#5553) (Boshen) ### Features - 2da5ad1 ast: Add `JSXElementName::get_identifier` method (#5556) (overlookmotel) - 2016bae coverage: Add regular expression idempotency test (#5676) (Boshen) - 68c3cf5 minifier: Fold `void 1` -> `void 0` (#5670) (Boshen) - c6bbf94 minifier: Constant fold unary expression (#5669) (Boshen) - 86256ea minifier: Constant fold `typeof` (#5666) (Boshen) - e698418 napi/transform: Align output `SourceMap` with Rollup's `ExistingRawSourceMap` (#5657) (Boshen) - aba9194 napi/transform: Export react refresh options (#5533) (underfin) - 642295c semantic: Add `SymbolTable::delete_resolved_reference` method (#5558) (overlookmotel) - b3cbd56 span: `format_compact_str!` macro (#5610) (overlookmotel) - 95a6d99 transformer: Enable the react refresh plugin in enable_all (#5630) (Dunqing) - 7b543df transformer/react: Handle `refresh_sig` and `refresh_reg` options correctly (#5638) (Dunqing) - 17226dd traverse: Add methods for deleting references (#5559) (overlookmotel) ### Bug Fixes - d62defb codegen: Do not print trailing commas for `ArrayExpression` (#5551) (Boshen) - 1bc08e2 coverage: Parse babel unambiguously (#5579) (Boshen) - 28b934c coverage: Apply `always_strict` to test262 and typescript per the specifcation (#5555) (Boshen) - b9bf544 isolated-declarations: False positive for setter method in `interface` (#5681) (Dunqing) - 6e8409a isolated-declarations: Bindings referenced in `TSModuleDeclaration` are removed incorrectly (#5680) (Dunqing) - b8f8dd6 minifier/replace_global_defines: Do not replace shadowed identifiers (#5691) (Boshen) - 304ce25 regular_expression: Keep LegacyOctalEscape raw digits for `to_string` (#5692) (leaysgur) - 0511d55 regular_expression: Report more MayContainStrings error in (nested)class (#5661) (leaysgur) - 41582ea regular_expression: Improve RegExp `to_string()` results (#5635) (leaysgur) - 28aad28 regular_expression: Handle `-` in `/[\-]/u` as escaped character (#5631) (leaysgur) - f9e3a41 semantic: Bind `SymbolId` to function name in `if (foo) function id() {}` (#5673) (Boshen) - f49e6eb span: Treat `.js` as `module` file (reverts the previous breaking change) (#5612) (Boshen) - 919d17f transform_conformance: Only print semantic mismatch errors when output is correct (#5589) (Boshen) - 505d064 transformer: JSX transform delete references for `JSXClosingElement`s (#5560) (overlookmotel) - 9b7ecc7 transformer: RegExp transform only set span on final expression (#5508) (overlookmotel) - d1ece19 transformer: RegExp transform handle `Term::Quantifier` (#5501) (overlookmotel) - a1afd48 transformer/react: Incorrect scope_id for var hoisted in fast refresh plugin (#5695) (Dunqing) - f2f5e5a transformer/react: Missing scope_id for function in fast refresh plugin (#5693) (Dunqing) - a891c31 transformer/react: Refresh plugin has incorrect reference flags (#5656) (Dunqing) - 3e8b96f transformer/react: The refresh plugin cannot handle member expressions with React hooks (#5655) (Dunqing) - 0739b5f transformer/react: Don't transform declaration of function overloads (#5642) (Dunqing) - 3bf6aaf transformer/react: Support `emit_full_signatures` option in refresh plugin (#5629) (Dunqing) - 36d864a transformer/react: Don't transform if the variable does not have a value reference (#5528) (Dunqing) ### Performance - e8013d2 traverse: Faster string operations generating UIDs (#5626) (overlookmotel) - 4996874 traverse: `generate_uid` cache available binding names (#5611) (overlookmotel) ### Documentation - fefbbc1 sourcemap: Add trailing newline to README (#5539) (overlookmotel) - 9282647 transformer: Comment on RegExp transform for potential improvement (#5514) (overlookmotel) - 1c051ae traverse: Correct code comment 2 (#5607) (overlookmotel) - 2e24a15 traverse: Correct code comment (#5604) (overlookmotel) ### Refactor - 14ee086 ast: Inline `AstKind::as_*` methods (#5547) (overlookmotel) - 2de6ea0 index, traverse: Remove unnecessary type annotations (#5650) (overlookmotel) - 0ac420d linter: Use meaningful names for diagnostic parameters (#5564) (Don Isaac) - 2da42ef regular_expression: Improve AST docs with refactoring may_contain_strings (#5665) (leaysgur) - dec1395 regular_expression: Align diagnostics (#5543) (leaysgur) - 731ffaa semantic: Compare nodes by pointer equality (#5686) (overlookmotel) - 067f9b5 semantic: Introduce `IsGlobalReference` trait (#5672) (Boshen) - d22a9b7 semantic: `SymbolTable::is_empty` use `is_empty` (#5622) (overlookmotel) - 3d190a5 span: Move `CompactStr` into separate file (#5609) (overlookmotel) - 5532628 span: Put types and impl in the same mod file (Boshen) - ce71982 transformer: Shorten code in JSX transform (#5554) (overlookmotel) - 758a10c transformer: RegExp transform reuse var (#5527) (overlookmotel) - fad0a05 transformer: RegExp transform unbox early (#5504) (overlookmotel) - 19cdcc5 traverse: Revert changes to `walk.rs` (#5652) (overlookmotel)- 26d9235 Enable clippy::ref_as_ptr (#5577) (夕舞八弦) ### Styling - e52d006 traverse: Fix formatting of traverse codegen (#5651) (overlookmotel) - 97e99bd traverse: Remove excess line break (#5603) (overlookmotel)- 694f032 Add trailing line breaks to `package.json` files (#5542) (overlookmotel) ### Testing - 2e367c9 traverse: Enable tests for `oxc_traverse` crate (#5625) (overlookmotel)- dc92489 Add trailing line breaks to conformance fixtures (#5541) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 9, 2024

This was referenced Sep 9, 2024

feat(transformer/react): handle refresh_sig and refresh_reg options correctly #5638

Merged

fix(transformer/react): don't transform declaration of function overloads #5642

Merged

Dunqing force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from e828a13 to 1234d0d Compare September 9, 2024 09:35

Dunqing changed the base branch from 09-08-fix_transformer_react_support_emit_full_signatures_option_in_refresh_plugin to 09-09-fix_transformer_react_don_t_transform_declaration_of_function_overloads September 9, 2024 09:35

Dunqing mentioned this pull request Sep 9, 2024

chore(transformer): treat all React Refresh tests as ESM syntax #5644

Merged

Dunqing force-pushed the 09-09-fix_transformer_react_don_t_transform_declaration_of_function_overloads branch from 7e88054 to a4e0c52 Compare September 9, 2024 10:50

Dunqing force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from 1234d0d to 6159d96 Compare September 9, 2024 10:51

Dunqing mentioned this pull request Sep 9, 2024

fix(transformer/react): the refresh plugin cannot handle member expressions with React hooks #5655

Merged

Dunqing force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from 6159d96 to 8428ca4 Compare September 9, 2024 15:25

Dunqing changed the base branch from 09-09-fix_transformer_react_don_t_transform_declaration_of_function_overloads to 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks September 9, 2024 15:25

Dunqing force-pushed the 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks branch from e3bb2bc to 5759d2b Compare September 9, 2024 15:27

Dunqing force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from 8428ca4 to ce18941 Compare September 9, 2024 15:27

Dunqing mentioned this pull request Sep 9, 2024

fix(transformer/react): refresh plugin has incorrect reference flags #5656

Merged

Dunqing force-pushed the 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks branch from 5759d2b to 413d918 Compare September 9, 2024 15:41

Dunqing force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from ce18941 to 1d1ec5b Compare September 9, 2024 15:41

Dunqing force-pushed the 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks branch from 413d918 to 8c7b570 Compare September 10, 2024 06:21

Dunqing force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from 1d1ec5b to 8d00cb1 Compare September 10, 2024 06:21

Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 11, 2024 — with Graphite App

Boshen force-pushed the 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks branch from 8c7b570 to 10a50a2 Compare September 11, 2024 07:18

Boshen force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from 8d00cb1 to e7b1675 Compare September 11, 2024 07:19

feat(transformer): enable the react refresh plugin in enable_all (#5630)

95a6d99

Boshen force-pushed the 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks branch from 10a50a2 to 3e8b96f Compare September 11, 2024 07:59

Boshen force-pushed the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch from e7b1675 to 95a6d99 Compare September 11, 2024 07:59

Base automatically changed from 09-09-fix_transformer_react_the_refresh_plugin_cannot_handle_member_expressions_with_react_hooks to main September 11, 2024 08:07

graphite-app bot merged commit 95a6d99 into main Sep 11, 2024

graphite-app bot deleted the 09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all branch September 11, 2024 08:08

oxc-bot mentioned this pull request Sep 11, 2024

release(oxc): crates v0.28.0 #5696

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(transformer): enable the react refresh plugin in enable_all#5630

feat(transformer): enable the react refresh plugin in enable_all#5630
graphite-app[bot] merged 1 commit intomainfrom
09-09-feat_transformer_enable_the_react_refresh_plugin_in_enable_all

Dunqing commented Sep 9, 2024

Uh oh!

graphite-app bot commented Sep 9, 2024

Uh oh!

Dunqing commented Sep 9, 2024 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 9, 2024 •

edited

Loading

Uh oh!

Dunqing commented Sep 10, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 11, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

Dunqing commented Sep 9, 2024

Uh oh!

graphite-app bot commented Sep 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

Dunqing commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #5630 will degrade performances by 42.9%

Summary

Benchmarks breakdown

Uh oh!

Dunqing commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dunqing commented Sep 9, 2024 •

edited

Loading

codspeed-hq bot commented Sep 9, 2024 •

edited

Loading

Dunqing commented Sep 10, 2024 •

edited

Loading

graphite-app bot commented Sep 11, 2024 •

edited

Loading