Skip to content

Comments

feat(linter): Implement eslint/no-invalid-regexp#5583

Closed
leaysgur wants to merge 1 commit intomainfrom
no-invalid-regexp-2
Closed

feat(linter): Implement eslint/no-invalid-regexp#5583
leaysgur wants to merge 1 commit intomainfrom
no-invalid-regexp-2

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Sep 7, 2024

Debugging perf drop for #5443 ...

@github-actions github-actions bot added the A-linter Area - Linter label Sep 7, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #5583 will degrade performances by 36.91%

Comparing no-invalid-regexp-2 (1573997) with main (5f27551)

Summary

❌ 2 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main no-invalid-regexp-2 Change
linter[cal.com.tsx] 858 ms 1,342.2 ms -36.07%
linter[checker.ts] 1.5 s 2.4 s -36.91%

@leaysgur leaysgur closed this Sep 7, 2024
@leaysgur leaysgur deleted the no-invalid-regexp-2 branch September 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant