feat(oxc_cfg): add implicit return instruction#5568
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
IWANABETHATGUY
changed the title
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #5568 will not alter performanceComparing Summary
|
IWANABETHATGUY
changed the title
rzvxa
previously requested changes
Sep 7, 2024
Contributor
rzvxa
left a comment
rzvxa
left a comment
There was a problem hiding this comment.
We should also do the same thing for the visit_arrow_function_expression method.
IWANABETHATGUY
force-pushed
the
feat/add-implicit-return-inst
branch
from
5dc427b to
aa0ba23
Compare
IWANABETHATGUY
force-pushed
the
feat/add-implicit-return-inst
branch
3 times, most recently
from
809ffae to
c0d4117
Compare
Member
|
Waiting for @rzvxa to take a look. |
Boshen
force-pushed
the
feat/add-implicit-return-inst
branch
from
c0d4117 to
3f5e1a2
Compare
This was referenced Nov 21, 2024
Boshen
added a commit
that referenced
this pull request
Nov 21, 2024
## [0.13.0] - 2024-11-21 - 7bf970a linter: [**BREAKING**] Remove tree_shaking plugin (#7372) (Boshen) - 7f8747d linter: Implement `react/no-array-index-key` (#6960) (BitterGourd) ### Features - be152c0 linter: Add `typescript/no-require-imports` rule (#7315) (Dmitry Zakharov) - 849489e linter: Add suggestion for no-console (#4312) (DonIsaac) - 8cebdc8 linter: Allow appending plugins in override (#7379) (camchenry) - 8cfea3c oxc_cfg: Add implicit return instruction (#5568) (IWANABETHATGUY) - e6922df parser: Fix incorrect AST for `x?.f<T>()` (#7387) (Boshen) ### Bug Fixes - e91c287 linter: Fix panic in react/no-array-index-key (#7395) (Boshen) - a32f5a7 linter/no-array-index-key: Compile error due to it uses a renamed API (#7391) (Dunqing) - 666b6c1 parser: Add missing `ChainExpression` in optional `TSInstantiationExpression` (#7371) (Boshen) ### Documentation - df143ca linter: Add docs for config settings (#4827) (DonIsaac) - ad44cfa linter: Import/first options (#7381) (Zak) ### Refactor - c34d649 linter: Use `scope_id` etc methods (#7394) (overlookmotel) - 466f395 vscode: Split `ConfigService` and `Config` (#7376) (Alexander S.) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImplicitReturnImplicitReturninstruction for each function body, just like biome