Closed
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-semantic
CodSpeed Performance ReportMerging #5529 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
upgrade-script
branch
2 times, most recently
from
7a57a1a to
e1b43ad
Compare
Contributor
|
I added a test case from Babel 😈 |
Boshen
force-pushed
the
upgrade-script
branch
from
997246e to
b2d5716
Compare
Boshen
commented
Sep 6, 2024
| Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/core/sourcetype-unambiguous/import-meta/input.js | ||
|
|
||
| × Unexpected import.meta expression | ||
| ╭─[babel/packages/babel-parser/test/fixtures/core/sourcetype-unambiguous/import-meta/input.js:1:13] |
Member
Author
There was a problem hiding this comment.
Need sawUnambiguousESM from babel parrser
Boshen
commented
Sep 6, 2024
| Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/arrayFromAsync.ts | ||
|
|
||
| × Expected `(` but found `await` | ||
| ╭─[typescript/tests/cases/compiler/arrayFromAsync.ts:22:5] |
Member
Author
There was a problem hiding this comment.
Need to check for syntax later.
Boshen
commented
Sep 6, 2024
| · ────── | ||
| 4 │ | ||
| × Private identifier '#bar' is not allowed outside class bodies | ||
| ╭─[typescript/tests/cases/conformance/salsa/privateIdentifierExpando.ts:2:3] |
Member
Author
|
I'll try and fix the issues in a stack. |
Member
Author
|
Reworked this in the stack #5557 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://babel.dev/docs/options#sourcetype