Skip to content

fix(linter): tree_shaking/no_side_effects_in_initialization handle JSX correctly #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Sep 5, 2024
Merged

fix(linter): tree_shaking/no_side_effects_in_initialization handle JSX correctly #5450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 16 additions & 34 deletions crates/oxc_linter/src/rules/tree_shaking/no_side_effects_in_initialization/listener_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ use oxc_ast::{
ConditionalExpression, Declaration, ExportSpecifier, Expression, ForStatementInit,
FormalParameter, Function, IdentifierReference, JSXAttribute, JSXAttributeItem,
JSXAttributeValue, JSXChild, JSXElement, JSXElementName, JSXExpression,
JSXExpressionContainer, JSXFragment, JSXIdentifier, JSXOpeningElement, LogicalExpression,
MemberExpression, NewExpression, ObjectExpression, ObjectPropertyKind,
ParenthesizedExpression, PrivateFieldExpression, Program, PropertyKey, SequenceExpression,
SimpleAssignmentTarget, Statement, StaticMemberExpression, SwitchCase, ThisExpression,
UnaryExpression, VariableDeclarator,
JSXExpressionContainer, JSXFragment, JSXMemberExpression, JSXMemberExpressionObject,
JSXOpeningElement, LogicalExpression, MemberExpression, NewExpression, ObjectExpression,
ObjectPropertyKind, ParenthesizedExpression, PrivateFieldExpression, Program, PropertyKey,
SequenceExpression, SimpleAssignmentTarget, Statement, StaticMemberExpression, SwitchCase,
ThisExpression, UnaryExpression, VariableDeclarator,
},
AstKind,
};
Expand Down Expand Up @@ -788,41 +788,24 @@ impl<'a> ListenerMap for JSXOpeningElement<'a> {
impl<'a> ListenerMap for JSXElementName<'a> {
fn report_effects_when_called(&self, options: &NodeListenerOptions) {
match self {
Self::Identifier(ident) => ident.report_effects_when_called(options),
Self::Identifier(_) | Self::NamespacedName(_) => {}
Self::IdentifierReference(ident) => ident.report_effects_when_called(options),
Self::NamespacedName(name) => name.property.report_effects_when_called(options),
Self::MemberExpression(member) => {
member.property.report_effects_when_called(options);
}
Self::MemberExpression(member) => member.report_effects_when_called(options),
}
}
}

impl<'a> ListenerMap for JSXIdentifier<'a> {
impl<'a> ListenerMap for JSXMemberExpression<'a> {
fn report_effects_when_called(&self, options: &NodeListenerOptions) {
if self.name.chars().next().is_some_and(char::is_uppercase) {
let Some(symbol_id) = options.ctx.symbols().get_symbol_id_from_name(&self.name) else {
options.ctx.diagnostic(super::call_global(self.name.as_str(), self.span));
return;
};
self.object.report_effects_when_called(options);
}
}

for reference in options.ctx.symbols().get_resolved_references(symbol_id) {
if reference.is_write() {
let node_id = reference.node_id();
if let Some(expr) = get_write_expr(node_id, options.ctx) {
let old_val = options.called_with_new.get();
options.called_with_new.set(true);
expr.report_effects_when_called(options);
options.called_with_new.set(old_val);
}
}
}
let symbol_table = options.ctx.semantic().symbols();
let node = options.ctx.nodes().get_node(symbol_table.get_declaration(symbol_id));
let old_val = options.called_with_new.get();
options.called_with_new.set(true);
node.report_effects_when_called(options);
options.called_with_new.set(old_val);
impl<'a> ListenerMap for JSXMemberExpressionObject<'a> {
fn report_effects_when_called(&self, options: &NodeListenerOptions) {
match self {
Self::IdentifierReference(ident) => ident.report_effects_when_called(options),
Self::MemberExpression(member) => member.report_effects_when_called(options),
}
}
}
Expand Down Expand Up @@ -1140,7 +1123,6 @@ impl<'a> ListenerMap for IdentifierReference<'a> {
);

if is_used_in_jsx {
// TODO: remove the repeat the same logic in `JSXIdentifier::report_effects_when_called` method
for reference in options.ctx.symbols().get_resolved_references(symbol_id) {
if reference.is_write() {
let node_id = reference.node_id();
Expand Down
6 changes: 3 additions & 3 deletions crates/oxc_linter/src/snapshots/no_side_effects_in_initialization.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,10 +817,10 @@ source: crates/oxc_linter/src/tester.rs
· ───
╰────

⚠ eslint-plugin-tree-shaking(no-side-effects-in-initialization): Cannot determine side-effects of calling global function `Y`
╭─[no_side_effects_in_initialization.tsx:1:34]
⚠ eslint-plugin-tree-shaking(no-side-effects-in-initialization): Cannot determine side-effects of calling
╭─[no_side_effects_in_initialization.tsx:1:11]
1 │ const X = {Y: ext}; const x = <X.Y />
· ─
· ────────
╰────

⚠ eslint-plugin-tree-shaking(no-side-effects-in-initialization): Cannot determine side-effects of calling global function `ext`
Expand Down