Skip to content

perf(linter): avoid unnecessary work in jsx_a11y/anchor_is_valid rule #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 30, 2024
Merged

perf(linter): avoid unnecessary work in jsx_a11y/anchor_is_valid rule #5341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions crates/oxc_linter/src/rules/jsx_a11y/anchor_is_valid.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ impl Rule for AnchorIsValid {
if name != "a" {
return;
};
let span = jsx_el.opening_element.name.span();
// Don't eagerly get `span` here, to avoid that work unless rule fails
let get_span = || jsx_el.opening_element.name.span();
if let Option::Some(href_attr) =
has_jsx_prop_ignore_case(&jsx_el.opening_element, "href")
{
Expand All @@ -145,17 +146,17 @@ impl Rule for AnchorIsValid {

// Check if the 'a' element has a correct href attribute
let Some(value) = attr.value.as_ref() else {
ctx.diagnostic(incorrect_href(span));
ctx.diagnostic(incorrect_href(get_span()));
return;
};

let is_empty = self.check_value_is_empty(value);
if is_empty {
if has_jsx_prop_ignore_case(&jsx_el.opening_element, "onclick").is_some() {
ctx.diagnostic(cant_be_anchor(span));
ctx.diagnostic(cant_be_anchor(get_span()));
return;
}
ctx.diagnostic(incorrect_href(span));
ctx.diagnostic(incorrect_href(get_span()));
return;
}
return;
Expand All @@ -168,7 +169,7 @@ impl Rule for AnchorIsValid {
if has_spread_attr {
return;
}
ctx.diagnostic(missing_href_attribute(span));
ctx.diagnostic(missing_href_attribute(get_span()));
}
}
}
Expand Down