Skip to content

fix(linter/unicorn): consistent-function-scoping false positive on assignment expression #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 6 commits into from
Aug 31, 2024
Merged

fix(linter/unicorn): consistent-function-scoping false positive on assignment expression #5312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e564b9
fix false scoping error on assignment expr
Arian94 Aug 28, 2024
0a44cc4
Merge branch 'fix/5159' of github.com:Arian94/oxc into fix/5159
Arian94 Aug 31, 2024
bc23ccb
add new fail test - improve error logging text accordingly
Arian94 Aug 31, 2024
b2a552b
refactor: use map to get func name span
Arian94 Aug 31, 2024
9416343
Merge branch 'main' into fix/5159
DonIsaac Aug 31, 2024
0f68456
fix: fix clippy error
camc314 Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ impl Rule for ConsistentFunctionScoping {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
let (function_declaration_symbol_id, function_body, reporter_span) = match node.kind() {
AstKind::Function(function) => {
if let Some(AstKind::AssignmentExpression(_)) = ctx.nodes().parent_kind(node.id()) {
return;
}

if function.is_typescript_syntax() {
return;
}
Expand All @@ -172,8 +176,12 @@ impl Rule for ConsistentFunctionScoping {
(
binding_ident.symbol_id.get().unwrap(),
function_body,
// 8 for "function"
Span::sized(function.span.start, 8),
function
.id
.as_ref()
.map_or(Span::sized(function.span.start, 8), |func_binding_ident| {
func_binding_ident.span
}),
)
} else if let Some(function_id) = &function.id {
(function_id.symbol_id.get().unwrap(), function_body, function_id.span())
Expand Down Expand Up @@ -573,6 +581,9 @@ fn test() {
("t.throws(() => receiveString(function a() {}), {})", None),
("function test () { t.throws(() => receiveString(function a() {}), {}) }", None),
("function foo() { let x = new Bar(function b() {}) }", None),
("module.exports = function foo() {};", None),
("module.exports.foo = function foo() {};", None),
("foo.bar.func = function foo() {};", None),
];

let fail = vec![
Expand Down Expand Up @@ -804,6 +815,7 @@ fn test() {
// ("const doFoo = () => bar => bar;", None),
("function foo() { const bar = async () => {} }", None),
("function doFoo() { const doBar = function(bar) { return bar; }; }", None),
("function outer() { const inner = function inner() {}; }", None),
];

Tester::new(ConsistentFunctionScoping::NAME, pass, fail).test_and_snapshot();
Expand Down
7 changes: 7 additions & 0 deletions crates/oxc_linter/src/snapshots/consistent_function_scoping.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,3 +394,10 @@ source: crates/oxc_linter/src/tester.rs
· ────────
╰────
help: Move this function to the outer scope.

⚠ eslint-plugin-unicorn(consistent-function-scoping): Function does not capture any variables from the outer scope.
╭─[consistent_function_scoping.tsx:1:43]
1 │ function outer() { const inner = function inner() {}; }
· ─────
╰────
help: Move this function to the outer scope.