feat(linter) eslint-plugin-unicorn consistent function scoping

[camc314]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[camc314]

• feat(linter) eslint-plugin-unicorn consistent function scoping #4948 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #4948 will not alter performance

_{Comparing c/08-17-feat_linter_eslint-plugin-unicorn_consistent_function_scoping (247120f) with main (185eb20)}

Summary

✅ 29 untouched benchmarks

[DonIsaac]

Will review this afternoon.

[graphite-app]

Merge activity

• Aug 18, 11:24 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 18, 11:29 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
• Aug 18, 11:32 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

[Boshen]

This broke ecosystem CI, https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/10448337921/job/28928727073

Is category correctness correct here?

[DonIsaac]

I think so, but this should not ban callback functions. If @camc314 is unable to address this today then I will

[camc314]

maybe this rule should ignore tests?

  x eslint-plugin-unicorn(consistent-function-scoping): Function does not capture any variables from the outer scope.
   ,-[examples/napi/__tests__/error-msg.spec.ts:7:41]
 6 |   // @ts-expect-error
 7 |   t.throws(() => receiveString(function a() {}), {
   :                                         ^
 8 |     message:
   `----
  help: Move this function to the outer scope.

but i think it's ok for it to report call back functions? if you were adding an event listener multiple times, by moving the event listener to the outer scope (if possible), you avoid creating a function for each event you listen to - instead you'd just listen to one.

[Boshen]

We don't have a good way to detect test files.

The warnings in preact is way too much https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/10461140451/job/28969595249

Should we change the category or improve the rule to make ecosystem CI green?

[DonIsaac]

IMO, let's change the level until an improvement is merged. I'll get this in.

[DonIsaac]

https://app.graphite.dev/github/pr/oxc-project/oxc/5010/fix-linter-change-consistent-function-scoping-to-suspicious

#5010