Skip to content

feat(linter): eslint-plugin-vitest/require-local-test-context-for-concurrent-snapshots#4796

Closed
eryue0220 wants to merge 2 commits intooxc-project:mainfrom
eryue0220:feat/lint-require-local-test-context-for-concurrent-snapshots
Closed

feat(linter): eslint-plugin-vitest/require-local-test-context-for-concurrent-snapshots#4796
eryue0220 wants to merge 2 commits intooxc-project:mainfrom
eryue0220:feat/lint-require-local-test-context-for-concurrent-snapshots

Conversation

@eryue0220
Copy link
Contributor

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 10, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 10, 2024

CodSpeed Performance Report

Merging #4796 will not alter performance

Comparing eryue0220:feat/lint-require-local-test-context-for-concurrent-snapshots (30adf8a) with main (857bc73)

Summary

✅ 29 untouched benchmarks

);

impl Rule for RequireLocalTestContextForConcurrentSnapshots {
fn run_once(&self, ctx: &LintContext) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't need to collect function parameters? We can iterate all expect call expression and combine you check method

https://github.com/veritem/eslint-plugin-vitest/blob/8b11357b8690c276b869a04140f5238679bab5de/src/rules/require-local-test-context-for-concurrent-snapshots.ts#L33

@mysteryven
Copy link
Contributor

Could you split a PR that doesn't contain require-local-test-context-for-concurrent-snapshots? Let's merge the bug fixes first, maybe in #4797 ?

@eryue0220
Copy link
Contributor Author

Could you split a PR that doesn't contain require-local-test-context-for-concurrent-snapshots? Let's merge the bug fixes first, maybe in #4797 ?

Done.

@eryue0220 eryue0220 marked this pull request as draft August 12, 2024 03:10
@mysteryven
Copy link
Contributor

Close because of duplicated: #4951.

Thanks for your work on this rule.

@mysteryven mysteryven closed this Aug 20, 2024
@eryue0220 eryue0220 deleted the feat/lint-require-local-test-context-for-concurrent-snapshots branch August 21, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants