Skip to content

feat(linter): add fixer for jsx_ally/no_aria_hidden_on_focusable #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mysteryven merged 1 commit into from
Aug 9, 2024
Merged

feat(linter): add fixer for jsx_ally/no_aria_hidden_on_focusable #4772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions crates/oxc_linter/src/rules/jsx_a11y/no_aria_hidden_on_focusable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ declare_oxc_lint!(
/// <div aria-hidden="true" />
/// ```
NoAriaHiddenOnFocusable,
correctness
correctness,
fix
);

impl Rule for NoAriaHiddenOnFocusable {
Expand All @@ -49,7 +50,10 @@ impl Rule for NoAriaHiddenOnFocusable {
if let Some(aria_hidden_prop) = has_jsx_prop_ignore_case(jsx_el, "aria-hidden") {
if is_aria_hidden_true(aria_hidden_prop) && is_focusable(ctx, jsx_el) {
if let JSXAttributeItem::Attribute(boxed_attr) = aria_hidden_prop {
ctx.diagnostic(no_aria_hidden_on_focusable_diagnostic(boxed_attr.span));
ctx.diagnostic_with_fix(
no_aria_hidden_on_focusable_diagnostic(boxed_attr.span),
|fixer| fixer.delete(&boxed_attr.span),
);
}
}
}
Expand Down Expand Up @@ -127,5 +131,14 @@ fn test() {
r#"<p tabIndex="0" aria-hidden="true">text</p>;"#,
];

Tester::new(NoAriaHiddenOnFocusable::NAME, pass, fail).test_and_snapshot();
let fix = vec![
(r#"<div aria-hidden="true" tabIndex="0" />;"#, r#"<div tabIndex="0" />;"#),
(r#"<input aria-hidden="true" />;"#, "<input />;"),
(r#"<a href="/" aria-hidden="true" />"#, r#"<a href="/" />"#),
(r#"<button aria-hidden="true" />"#, "<button />"),
(r#"<textarea aria-hidden="true" />"#, "<textarea />"),
(r#"<p tabIndex="0" aria-hidden="true">text</p>;"#, r#"<p tabIndex="0" >text</p>;"#),
];

Tester::new(NoAriaHiddenOnFocusable::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}