Skip to content

refactor(ast_codegen): remove Generator::name and Pass::name methods #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 8, 2024
Merged

refactor(ast_codegen): remove Generator::name and Pass::name methods #4764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tasks/ast_codegen/src/generators/assert_layouts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ define_generator! {
}

impl Generator for AssertLayouts {
fn name(&self) -> &'static str {
stringify!(AssertLayouts)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
let (assertions_64, assertions_32) = ctx
.schema
Expand Down
4 changes: 0 additions & 4 deletions tasks/ast_codegen/src/generators/ast_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ define_generator! {
}

impl Generator for AstBuilderGenerator {
fn name(&self) -> &'static str {
stringify!(AstBuilderGenerator)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
let fns = ctx
.schema
Expand Down
4 changes: 0 additions & 4 deletions tasks/ast_codegen/src/generators/ast_kind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,6 @@ pub fn process_types(def: &TypeDef, _: &LateCtx) -> Vec<(Ident, Type)> {
}

impl Generator for AstKindGenerator {
fn name(&self) -> &'static str {
stringify!(AstKindGenerator)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
let have_kinds: Vec<(Ident, Type)> = ctx
.schema.definitions
Expand Down
4 changes: 0 additions & 4 deletions tasks/ast_codegen/src/generators/derive_clone_in.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ define_generator! {
}

impl Generator for DeriveCloneIn {
fn name(&self) -> &'static str {
stringify!(DeriveCloneIn)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
let impls: Vec<TokenStream> = ctx
.schema
Expand Down
8 changes: 0 additions & 8 deletions tasks/ast_codegen/src/generators/derive_get_span.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ define_generator! {
}

impl Generator for DeriveGetSpan {
fn name(&self) -> &'static str {
stringify!(DeriveGetSpan)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
let trait_name = format_ident!("GetSpan");
let method_name = format_ident!("span");
Expand All @@ -37,10 +33,6 @@ define_generator! {
}

impl Generator for DeriveGetSpanMut {
fn name(&self) -> &'static str {
stringify!(DeriveGetSpanMut)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
let trait_name = format_ident!("GetSpanMut");
let method_name = format_ident!("span_mut");
Expand Down
3 changes: 1 addition & 2 deletions tasks/ast_codegen/src/generators/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ macro_rules! generated_header {
pub(crate) use generated_header;

pub trait Generator {
fn name(&self) -> &'static str;
fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput;
}

Expand All @@ -62,7 +61,7 @@ macro_rules! define_generator {
type Output = $crate::GeneratorOutput;

fn name(&self) -> &'static str {
$crate::Generator::name(self)
stringify!($ident)
}

fn run(&mut self, ctx: &$crate::LateCtx) -> $crate::Result<Self::Output> {
Expand Down
8 changes: 0 additions & 8 deletions tasks/ast_codegen/src/generators/visit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ define_generator! {
}

impl Generator for VisitGenerator {
fn name(&self) -> &'static str {
stringify!(VisitGenerator)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
GeneratorOutput::Stream((
output(crate::AST_CRATE, "visit.rs"),
Expand All @@ -39,10 +35,6 @@ impl Generator for VisitGenerator {
}

impl Generator for VisitMutGenerator {
fn name(&self) -> &'static str {
stringify!(VisitMutGenerator)
}

fn generate(&mut self, ctx: &LateCtx) -> GeneratorOutput {
GeneratorOutput::Stream((
output(crate::AST_CRATE, "visit_mut.rs"),
Expand Down
4 changes: 0 additions & 4 deletions tasks/ast_codegen/src/passes/calc_layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ define_pass! {
}

impl Pass for CalcLayout {
fn name(&self) -> &'static str {
stringify!(CalcLayout)
}

fn each(&mut self, ty: &mut AstType, ctx: &EarlyCtx) -> crate::Result<bool> {
calc_layout(ty, ctx)
}
Expand Down
4 changes: 0 additions & 4 deletions tasks/ast_codegen/src/passes/linker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ define_pass! {
}

impl Pass for Linker {
fn name(&self) -> &'static str {
stringify!(Linker)
}

/// # Panics
/// On invalid inheritance.
fn each(&mut self, ty: &mut AstType, ctx: &EarlyCtx) -> crate::Result<bool> {
Expand Down
4 changes: 1 addition & 3 deletions tasks/ast_codegen/src/passes/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ pub use calc_layout::CalcLayout;
pub use linker::Linker;

pub trait Pass {
fn name(&self) -> &'static str;

/// Returns false if can't resolve
fn once(&mut self, _ctx: &EarlyCtx) -> Result<bool> {
Ok(true)
Expand Down Expand Up @@ -53,7 +51,7 @@ macro_rules! define_pass {
type Context = $crate::EarlyCtx;
type Output = ();
fn name(&self) -> &'static str {
$crate::Pass::name(self)
stringify!($ident)
}

fn run(&mut self, ctx: &Self::Context) -> $crate::Result<Self::Output> {
Expand Down