perf(linter): disable lint rules by file type #4380

DonIsaac · 2024-07-21T03:14:01Z

TL;DR

Added a should_run function to multiple lint rules to determine if a rule should be executed based on the source type. This change optimizes the linting process by avoiding unnecessary rule checks.

What changed?

New Method: Introduced the should_run method in the Rule trait.
Implementation: Implemented the should_run method for various lint rules, particularly those related to React and TypeScript.
Usage: Updated the Linter to use the should_run method to filter rules before execution.
Macro Update: Modified the declare_all_lint_rules macro to incorporate the should_run method.

How to test?

Run the linter on a project containing React and TypeScript files.
Verify that only relevant rules are executed based on the file type (e.g., JSX rules for React files).

Why make this change?

This change improves the performance of the linter by ensuring that only applicable rules are run for a given file type, reducing unnecessary computation and potential false positives.

graphite-app · 2024-07-21T03:14:06Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

DonIsaac · 2024-07-21T03:14:14Z

perf(linter): disable lint rules by file type #4380 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

codspeed-hq · 2024-07-21T03:21:20Z

CodSpeed Performance Report

Merging #4380 will not alter performance

_{Comparing don/07-20-perf_linter_disable_lint_rules_by_file_type (f7da22d) with main (f7da22d)}

Summary

✅ 32 untouched benchmarks

Boshen · 2024-07-21T07:27:46Z

The summary feels AI generated 👀

mysteryven · 2024-07-21T08:35:03Z

Found Several checks can be removed in favor of this PR

oxc/crates/oxc_linter/src/rules/typescript/no_this_alias.rs

Lines 90 to 92 in a207923

    
           if !ctx.source_type().is_typescript() { 
        
               return; 
        
           }

oxc/crates/oxc_linter/src/rules/typescript/no_unsafe_declaration_merging.rs

Lines 39 to 41 in a207923

    
           if !ctx.source_type().is_typescript() { 
        
               return; 
        
           }

oxc/crates/oxc_linter/src/rules/typescript/no_var_requires.rs

Lines 37 to 39 in a207923

    
           if !ctx.source_type().is_typescript() { 
        
               return; 
        
           }

DonIsaac · 2024-07-21T13:28:15Z

The summary feels AI generated 👀

It is 👀

graphite-app · 2024-07-21T15:17:48Z

Merge activity

Jul 21, 11:17 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 21, 11:22 AM EDT: DonIsaac added this pull request to the Graphite merge queue.
Jul 21, 11:25 AM EDT: DonIsaac merged this pull request with the Graphite merge queue.

### TL;DR Added a `should_run` function to multiple lint rules to determine if a rule should be executed based on the source type. This change optimizes the linting process by avoiding unnecessary rule checks. ### What changed? 1. **New Method**: Introduced the `should_run` method in the `Rule` trait. 2. **Implementation**: Implemented the `should_run` method for various lint rules, particularly those related to React and TypeScript. 3. **Usage**: Updated the `Linter` to use the `should_run` method to filter rules before execution. 4. **Macro Update**: Modified the `declare_all_lint_rules` macro to incorporate the `should_run` method. ### How to test? 1. Run the linter on a project containing React and TypeScript files. 2. Verify that only relevant rules are executed based on the file type (e.g., JSX rules for React files). ### Why make this change? This change improves the performance of the linter by ensuring that only applicable rules are run for a given file type, reducing unnecessary computation and potential false positives. ---

## [0.7.0] - 2024-08-05 - 85a7cea semantic: [**BREAKING**] Remove name from `reference` (#4329) (Dunqing) ### Features - aaee07e ast: Add `AstKind::AssignmentTargetPattern`, `AstKind::ArrayAssignmentTarget` and `AstKind::ObjectAssignmentTarget` (#4456) (Dunqing) - 9df7b56 jsx-a11y/no-autofocus: Implement fixer support (#4171) (Jelle van der Waa) - b87bf70 linter: Add fix capabilties to existing lint rules (#4560) (DonIsaac) - ddd8b27 linter: Support conditional fix capabilities (#4559) (DonIsaac) - b952942 linter: Add eslint/no-unused-vars (⭐ attempt 3.2) (#4445) (DonIsaac) - 6543958 linter: Add auto-fix metadata to RuleMeta (#4557) (Don Isaac) - 85e8418 linter: Add react/jsx-curly-brace-presence (#3949) (Don Isaac) - 4c4da56 linter: Add typescript-eslint/prefer-keyword-namespce (#4438) (Aza Walker) - d8c2a83 linter: Eslint-plugin-vitest/no-import-node-test (#4440) (cinchen) - e3b0c40 linter: Eslint-plugin-vitest/no-identical-title (#4422) (cinchen) - c936782 linter: Eslint-plugin-vitest/no-conditional-expect (#4425) (cinchen) - 27fdd69 linter: Eslint-plugin-vitest/no-commented-out-tests (#4424) (cinchen) - 51f5025 linter: Add fixer for unicorn/prefer-string-starts-ends-with (#4378) (DonIsaac) - 3c0c709 linter: Add typescript-eslint/no-extraneous-class (#4357) (Jaden Rodriguez) - 7afa1f0 linter: Support suggestions and dangerous fixes (#4223) (DonIsaac) - acc5729 linter: Eslint-plugin-vitest/expect-expect (#4299) (cinchen) - 2213f93 linter: Eslint-plugin-vitest/no-alias-methods (#4301) (cinchen) - c296bc3 linter/eslint: Implement func-names (#4618) (Alexander S.) - e116ae0 linter/eslint: Implement fixer for prefer-numeric-literals (#4591) (Jelle van der Waa) - eaf834f linter/eslint: Implement prefer-numeric-literals (#4109) (Jelle van der Waa) - db2fd70 linter/eslint-plugin-promise: Implement no-webpack-loader-syntax (#4331) (Jelle van der Waa) - 5f1e070 linter/eslint-plugin-unicorn: Add fixer for prefer-code-point (#4353) (Jelle van der Waa) - ed49e16 linter/eslint-plugin-unicorn: Implement fixer for prefer-dom-node-append (#4306) (Jelle van der Waa) - e2b15ac linter/react: Implement react-jsx-boolean-value (#4613) (Jelle van der Waa) - 68efcd4 linter/react-perf: Handle new objects and arrays in prop assignment patterns (#4396) (DonIsaac) ### Bug Fixes - 368112c ast: Remove `#[visit(ignore)]` from `ExportDefaultDeclarationKind`'s `TSInterfaceDeclaration` (#4497) (Dunqing) - d384f60 ci: Remove unused(?) .html file (#4545) (Yuji Sugiura) - 06aec77 linter: Invalid binary expression with overflow (#4647) (DonIsaac) - b2da22b linter: Invalid tags in rule docs (#4646) (DonIsaac) - 94440ad linter: Panic on invalid lang in `a11y/lang`. (#4630) (rzvxa) - e0b03f8 linter: Improve the boundary for eslint/for-direction (#4590) (heygsc) - 70b8cfa linter: Missing return in no-obj-calls recursion (#4594) (DonIsaac) - fe1356d linter: Change no-unused-vars to nursery (#4588) (DonIsaac) - 72337b1 linter: Change typescript-eslint/no-namespace to restriction (#4539) (Don Isaac) - 732f4e2 linter: Fix `oxlint` allocator cfg (#4527) (overlookmotel) - 289dc39 linter: Overflow in no-obj-calls (#4397) (DonIsaac) - a664715 linter/eslint: Fix invalid regexp in no_regex_spaces test (#4605) (Yuji Sugiura) - 74fa75a linter/eslint: Drop quotes around max-params lint warning (#4608) (Jelle van der Waa) - 9fcd9ae linter/eslint: Fix invalid regexp in no_control_regex test (#4544) (leaysgur) - ac08de8 linter/react_perf: Allow new objects, array, fns, etc in top scope (#4395) (DonIsaac) - 0fba738 npm: SyntaxError caused by optional chaining in low version node (#4650) (heygsc) - 73d2558 oxlint: Fix oxlint failed to build due to missing feature (Boshen) ### Performance - 6ff200d linter: Change react rules and utils to use `Cow` and `CompactStr` instead of `String` (#4603) (DonIsaac) - f259df0 linter: Make img-redundant-alt only build a regex once (#4604) (DonIsaac) - 7585e16 linter: Remove allocations for string comparisons (#4570) (DonIsaac) - b60bdf1 linter: `no_shadow_restricted_names` only look up name in hashmap once (#4472) (overlookmotel) - 81384f5 linter: Avoid unnecessary work in `nextjs:no_duplicate_head` rule (#4465) (overlookmotel) - f7da22d linter: Disable lint rules by file type (#4380) (DonIsaac) - 348c1ad semantic: Remove `span` field from `Reference` (#4464) (overlookmotel) - 6a9f4db semantic: Reduce storage size for symbol redeclarations (#4463) (overlookmotel)- a207923 Replace some CompactStr usages with Cows (#4377) (DonIsaac) ### Refactor - 7a75e0f linter: Use diagnostic codes in lint rules (#4349) (DonIsaac) - ccb1835 semantic: Methods take `Span` as param, not `&Span` (#4470) (overlookmotel) - 7cd53f3 semantic: Var hoisting (#4379) (Dunqing) - c99b3eb syntax: Give `ScopeId` a niche (#4468) (overlookmotel) Co-authored-by: Boshen <[email protected]>

github-actions bot added the A-linter Area - Linter label Jul 21, 2024

DonIsaac added the C-performance Category - Solution not expected to change functional behavior, only performance label Jul 21, 2024 — with Graphite App

DonIsaac marked this pull request as ready for review July 21, 2024 03:26

mysteryven approved these changes Jul 21, 2024

View reviewed changes

DonIsaac force-pushed the don/07-20-perf_linter_disable_lint_rules_by_file_type branch from 8912490 to 25ba8ac Compare July 21, 2024 15:16

DonIsaac added the 0-merge Merge with Graphite Merge Queue label Jul 21, 2024

DonIsaac force-pushed the don/07-20-perf_linter_disable_lint_rules_by_file_type branch from 25ba8ac to cf1e896 Compare July 21, 2024 15:18

DonIsaac force-pushed the don/07-20-perf_linter_disable_lint_rules_by_file_type branch from cf1e896 to f7da22d Compare July 21, 2024 15:23

graphite-app bot merged commit f7da22d into main Jul 21, 2024
23 checks passed

graphite-app bot deleted the don/07-20-perf_linter_disable_lint_rules_by_file_type branch July 21, 2024 15:25

oxc-bot mentioned this pull request Aug 5, 2024

Release oxlint v0.7.0 #4657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(linter): disable lint rules by file type #4380

perf(linter): disable lint rules by file type #4380

DonIsaac commented Jul 21, 2024 •

edited

Loading

graphite-app bot commented Jul 21, 2024

DonIsaac commented Jul 21, 2024

codspeed-hq bot commented Jul 21, 2024 •

edited

Loading

Boshen commented Jul 21, 2024

mysteryven commented Jul 21, 2024 •

edited

Loading

DonIsaac commented Jul 21, 2024

graphite-app bot commented Jul 21, 2024 •

edited

Loading

perf(linter): disable lint rules by file type #4380

perf(linter): disable lint rules by file type #4380

Conversation

DonIsaac commented Jul 21, 2024 • edited Loading

TL;DR

What changed?

How to test?

Why make this change?

graphite-app bot commented Jul 21, 2024

Your org has enabled the Graphite merge queue for merging into main

DonIsaac commented Jul 21, 2024

codspeed-hq bot commented Jul 21, 2024 • edited Loading

CodSpeed Performance Report

Merging #4380 will not alter performance

Summary

Boshen commented Jul 21, 2024

mysteryven commented Jul 21, 2024 • edited Loading

DonIsaac commented Jul 21, 2024

graphite-app bot commented Jul 21, 2024 • edited Loading

Merge activity

DonIsaac commented Jul 21, 2024 •

edited

Loading

codspeed-hq bot commented Jul 21, 2024 •

edited

Loading

mysteryven commented Jul 21, 2024 •

edited

Loading

graphite-app bot commented Jul 21, 2024 •

edited

Loading